New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixes and a little bit of refactoring #5

Merged
merged 12 commits into from Sep 28, 2016

Conversation

Projects
None yet
2 participants
@kulla
Contributor

kulla commented Aug 12, 2016

I used the template function relURL to make the link to the CSS stylesheet aware of the configured baseURL. Without this the browser cannot find the stylesheet when baseurl is set to a subdirectory of a server, i.e. baseurl = "http://example.com/hugo/".

@kulla

This comment has been minimized.

Contributor

kulla commented Aug 12, 2016

Oh I just noticed that after this commit the site does not work any more, if for example baseurl = "http://example.com/hugo/ and relativeURLs = true in config.toml... @masa0221 you may wait until you accept this pull request... :-)

This was referenced Aug 16, 2016

@kulla kulla changed the title from bugfix: use "relURL" to link to the CSS stylesheet to Some fixes and a little bit of refactoring Aug 16, 2016

@kulla

This comment has been minimized.

Contributor

kulla commented Aug 16, 2016

I just noticed that github automatically update this PR when I alter my master branch. I hope it's okay to have one big PR. The bug mentioned in my previous comment seem to be due to gohugoio/hugo#2227 and I hope it will be fixed in the future...

@masa0221

This comment has been minimized.

Owner

masa0221 commented Sep 28, 2016

@kulla
Thank you for Pull request, and great refactoring!
Sorry for the late response.
I confirmed all modified sources.
Sounds great!

LGTM

@masa0221 masa0221 merged commit 2f52fe9 into masa0221:master Sep 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment