New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing tests which use Test::Data::Scalar #2

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@netangel

netangel commented Nov 18, 2015

Hi! I have been received your module as CPAN PRC (Pull request challenge).
I've checked the issue about using Moo instead of Any::Mouse, but it doesn't make any sense for me, cause Any::Moose is being used only for tests, which is suitable enough.

BTW, while playing with your code, I've found some issues with tests. Here is the commit description:

Using dependencies from Makefile.pl we install Test::Data, but, since it's used as Test::Data::Scalar in Makefile, some tests are failing with:

Undefined subroutine &Test::Data::Scalar::ref_type_ok called

I've checked this issue on Mac OS X (10.9) and Ubuntu linux (14.14).
Changing dependency for tests to Test::Data is fixing this issue.

Also "use strict" and "use warnings" were added to improve Kwalitee :)

Fix failing tests which use Test::Data::Scalar
Using dependencies from Makefile.pl we install Test::Data
but as it defined as Test::Data::Scalar in Makefile some tests
are failing with:

Undefined subroutine &Test::Data::Scalar::ref_type_ok called

I've checked this issue on Mac OS X (10.9) and Ubuntu linux (14.14)

Also "use strict" and "use warnings" were added to improve Kwalitee :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment