From a4bd980ee53b2c5b927497135687d6a4870f20c2 Mon Sep 17 00:00:00 2001 From: masanbol Date: Sat, 2 Feb 2019 22:41:19 -0500 Subject: [PATCH] Revert "Refactor icons in web UI to use Icon component (#9951)" This reverts commit 1f9519020296c8c24a73d3f99d3c1ad94a627f3b. --- .eslintrc.js | 5 ----- .../mastodon/components/attachment_list.js | 5 ++--- .../mastodon/components/column_back_button.js | 3 +-- .../components/column_back_button_slim.js | 3 +-- .../mastodon/components/column_header.js | 15 +++++++------ app/javascript/mastodon/components/icon.js | 21 ------------------- .../mastodon/components/icon_button.js | 5 ++--- .../mastodon/components/load_gap.js | 3 +-- app/javascript/mastodon/components/status.js | 5 ++--- .../mastodon/components/status_content.js | 3 +-- .../features/account/components/header.js | 5 ++--- .../account_gallery/components/media_item.js | 3 +-- .../account_timeline/components/moved_note.js | 3 +-- .../compose/components/compose_form.js | 3 +-- .../compose/components/privacy_dropdown.js | 3 +-- .../features/compose/components/search.js | 5 ++--- .../compose/components/search_results.js | 11 +++++----- .../features/compose/components/upload.js | 5 ++--- .../compose/components/upload_progress.js | 3 +-- .../mastodon/features/compose/index.js | 15 +++++++------ .../features/getting_started/index.js | 3 +-- .../features/list_adder/components/list.js | 3 +-- .../features/list_editor/components/search.js | 5 ++--- .../mastodon/features/list_timeline/index.js | 5 ++--- .../components/clear_column_button.js | 3 +-- .../notifications/components/filter_bar.js | 9 ++++---- .../notifications/components/notification.js | 7 +++---- .../features/status/components/card.js | 7 +++---- .../status/components/detailed_status.js | 11 +++++----- .../mastodon/features/status/index.js | 3 +-- .../features/ui/components/boost_modal.js | 3 +-- .../features/ui/components/column_header.js | 3 +-- .../features/ui/components/column_link.js | 5 ++--- .../features/ui/components/columns_area.js | 3 +-- .../features/ui/components/media_modal.js | 5 ++--- .../features/ui/components/tabs_bar.js | 13 ++++++------ .../mastodon/features/video/index.js | 13 ++++++------ jest.config.js | 4 ---- 38 files changed, 82 insertions(+), 147 deletions(-) delete mode 100644 app/javascript/mastodon/components/icon.js diff --git a/.eslintrc.js b/.eslintrc.js index 177496d3a3d59..56e3d0530f591 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -41,11 +41,6 @@ module.exports = { 'node_modules', '\\.(css|scss|json)$', ], - 'import/resolver': { - node: { - paths: ['app/javascript'], - }, - }, }, rules: { diff --git a/app/javascript/mastodon/components/attachment_list.js b/app/javascript/mastodon/components/attachment_list.js index 5dfa1464c4fab..8e5bb0e0be85b 100644 --- a/app/javascript/mastodon/components/attachment_list.js +++ b/app/javascript/mastodon/components/attachment_list.js @@ -2,7 +2,6 @@ import React from 'react'; import ImmutablePropTypes from 'react-immutable-proptypes'; import PropTypes from 'prop-types'; import ImmutablePureComponent from 'react-immutable-pure-component'; -import Icon from 'mastodon/components/icon'; const filename = url => url.split('/').pop().split('#')[0].split('?')[0]; @@ -25,7 +24,7 @@ export default class AttachmentList extends ImmutablePureComponent { return (
  • - {filename(displayUrl)} + {filename(displayUrl)}
  • ); })} @@ -37,7 +36,7 @@ export default class AttachmentList extends ImmutablePureComponent { return (
    - +
      diff --git a/app/javascript/mastodon/components/column_back_button.js b/app/javascript/mastodon/components/column_back_button.js index f41045787e47e..8a60c4192a968 100644 --- a/app/javascript/mastodon/components/column_back_button.js +++ b/app/javascript/mastodon/components/column_back_button.js @@ -1,7 +1,6 @@ import React from 'react'; import { FormattedMessage } from 'react-intl'; import PropTypes from 'prop-types'; -import Icon from 'mastodon/components/icon'; export default class ColumnBackButton extends React.PureComponent { @@ -20,7 +19,7 @@ export default class ColumnBackButton extends React.PureComponent { render () { return ( ); diff --git a/app/javascript/mastodon/components/column_back_button_slim.js b/app/javascript/mastodon/components/column_back_button_slim.js index cc8bfb1515ba5..964c100befe44 100644 --- a/app/javascript/mastodon/components/column_back_button_slim.js +++ b/app/javascript/mastodon/components/column_back_button_slim.js @@ -1,7 +1,6 @@ import React from 'react'; import { FormattedMessage } from 'react-intl'; import ColumnBackButton from './column_back_button'; -import Icon from 'mastodon/components/icon'; export default class ColumnBackButtonSlim extends ColumnBackButton { @@ -9,7 +8,7 @@ export default class ColumnBackButtonSlim extends ColumnBackButton { return (
      - +
      diff --git a/app/javascript/mastodon/components/column_header.js b/app/javascript/mastodon/components/column_header.js index f33c689e7c6d1..f68e4155ebbc8 100644 --- a/app/javascript/mastodon/components/column_header.js +++ b/app/javascript/mastodon/components/column_header.js @@ -2,7 +2,6 @@ import React from 'react'; import PropTypes from 'prop-types'; import classNames from 'classnames'; import { FormattedMessage, injectIntl, defineMessages } from 'react-intl'; -import Icon from 'mastodon/components/icon'; const messages = defineMessages({ show: { id: 'column_header.show_settings', defaultMessage: 'Show settings' }, @@ -110,22 +109,22 @@ class ColumnHeader extends React.PureComponent { } if (multiColumn && pinned) { - pinButton = ; + pinButton = ; moveButtons = (
      - - + +
      ); } else if (multiColumn) { - pinButton = ; + pinButton = ; } if (!pinned && (multiColumn || showBackButton)) { backButton = ( ); @@ -141,7 +140,7 @@ class ColumnHeader extends React.PureComponent { } if (children || multiColumn) { - collapseButton = ; + collapseButton = ; } const hasTitle = icon && title; @@ -151,7 +150,7 @@ class ColumnHeader extends React.PureComponent {

      {hasTitle && ( )} diff --git a/app/javascript/mastodon/components/icon.js b/app/javascript/mastodon/components/icon.js deleted file mode 100644 index d8a17722fed2a..0000000000000 --- a/app/javascript/mastodon/components/icon.js +++ /dev/null @@ -1,21 +0,0 @@ -import React from 'react'; -import PropTypes from 'prop-types'; -import classNames from 'classnames'; - -export default class Icon extends React.PureComponent { - - static propTypes = { - id: PropTypes.string.isRequired, - className: PropTypes.string, - fixedWidth: PropTypes.bool, - }; - - render () { - const { id, className, fixedWidth, ...other } = this.props; - - return ( - - ); - } - -} diff --git a/app/javascript/mastodon/components/icon_button.js b/app/javascript/mastodon/components/icon_button.js index fbb42f78f8913..b96e48fd09937 100644 --- a/app/javascript/mastodon/components/icon_button.js +++ b/app/javascript/mastodon/components/icon_button.js @@ -3,7 +3,6 @@ import Motion from '../features/ui/util/optional_motion'; import spring from 'react-motion/lib/spring'; import PropTypes from 'prop-types'; import classNames from 'classnames'; -import Icon from 'mastodon/components/icon'; export default class IconButton extends React.PureComponent { @@ -87,7 +86,7 @@ export default class IconButton extends React.PureComponent { style={style} tabIndex={tabIndex} > -