Skip to content

refactor(isolation): isolation reconstruction #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 7, 2022
Merged

refactor(isolation): isolation reconstruction #30

merged 7 commits into from
Apr 7, 2022

Conversation

@zhenlei520
Copy link
Contributor

@zhenlei520 zhenlei520 commented Apr 2, 2022 •
edited
Loading

Chore

Docs

Refactor

Test

@zhenlei520 zhenlei520 requested a review from doddgu April 2, 2022 03:22
doddgu
doddgu approved these changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@doddgu doddgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/Isolation/Masa.Contrib.Isolation.MultiEnvironment/README.zh-CN.md
* 环境默认提供了7个解析器，执行顺序为：HttpContextItemParserProvider、QueryStringParserProvider、FormParserProvider、RouteParserProvider、HeaderParserProvider、CookieParserProvider、EnvironmentVariablesParserProvider (获取系统环境变量中的参数，默认环境隔离的参数：ASPNETCORE_ENVIRONMENT)
* HttpContextItemParserProvider: 通过请求的HttpContext的Items属性获取租户信息
* QueryStringParserProvider: 通过请求的QueryString获取环境信息
* https://github.com/masastack?ASPNETCORE_ENVIRONMENT=dev (环境信息是dev)
Copy link
Contributor

@doddgu doddgu Apr 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dev -> development?

Copy link
Contributor Author

@zhenlei520 zhenlei520 Apr 7, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default development environment is development, here is an example, abbreviated

@doddgu doddgu merged commit a024d11 into main Apr 7, 2022
@zhenlei520 zhenlei520 deleted the feature/isolation branch April 7, 2022 11:30
@zhenlei520 zhenlei520 mentioned this pull request Apr 18, 2022
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@doddgu doddgu doddgu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zhenlei520 @doddgu