Skip to content

fix(Storage.Aliyun): Whether the removal of Sts request is successful… #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 18, 2022
Merged

fix(Storage.Aliyun): Whether the removal of Sts request is successful… #62

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions src/Storage/Masa.Contrib.Storage.ObjectStorage.Aliyun/Client.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,19 +65,20 @@ protected virtual TemporaryCredentialsResponse GetTemporaryCredentials(
if (!string.IsNullOrEmpty(policy))
request.Policy = policy;
var response = client.GetAcsResponse(request);
if (response.HttpResponse.isSuccess())
{
return new TemporaryCredentialsResponse(
response.Credentials.AccessKeyId,
response.Credentials.AccessKeySecret,
response.Credentials.SecurityToken,
DateTime.Parse(response.Credentials.Expiration));
}

string message = $"Aliyun.Client: Failed to obtain temporary credentials, RequestId: {response.RequestId},Status: {response.HttpResponse.Status}, Message: {System.Text.Encoding.Default.GetString(response.HttpResponse.Content)}";
_logger?.LogWarning(message);

throw new Exception(message);
// if (response.HttpResponse.isSuccess())
// {
return new TemporaryCredentialsResponse( //todo: Get Sts response information is null, waiting for repair: https://github.com/aliyun/aliyun-openapi-net-sdk/pull/401
response.Credentials.AccessKeyId,
response.Credentials.AccessKeySecret,
response.Credentials.SecurityToken,
DateTime.Parse(response.Credentials.Expiration));
// }
//
// string message = $"Aliyun.Client: Failed to obtain temporary credentials, RequestId: {response.RequestId},Status: {response.HttpResponse.Status}, Message: {System.Text.Encoding.Default.GetString(response.HttpResponse.Content)}";
// _logger?.LogWarning(message);
//
// throw new Exception(message);
}

protected virtual void SetTemporaryCredentials(TemporaryCredentialsResponse credentials)
Expand Down