Skip to content

refactor(entityframework): Refactor SaveChange methods #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 18, 2022
Merged

refactor(entityframework): Refactor SaveChange methods #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
363e2be
chore: Optimize savechange filter
zhenlei520 May 18, 2022
6f24cf8
refactor(EntityFramework): Refactor SaveChangeAsync
zhenlei520 May 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/BuildingBlocks/MASA.BuildingBlocks
Open in desktop
Submodule MASA.BuildingBlocks updated 10 files
+2 −2 src/Ddd/Masa.BuildingBlocks.Ddd.Domain/Entities/AggregateRoot.cs
+34 −2 src/Ddd/Masa.BuildingBlocks.Ddd.Domain/Entities/Auditing/AuditAggregateRoot.cs
+1 −5 src/Ddd/Masa.BuildingBlocks.Ddd.Domain/Entities/Auditing/AuditEntity.cs
+7 −1 src/Ddd/Masa.BuildingBlocks.Ddd.Domain/Entities/Auditing/IAuditAggregateRoot.cs
+5 −1 src/Ddd/Masa.BuildingBlocks.Ddd.Domain/Entities/Auditing/IAuditEntity.cs
+16 −0 src/Ddd/Masa.BuildingBlocks.Ddd.Domain/Entities/Full/FullAggregateRoot.cs
+16 −0 src/Ddd/Masa.BuildingBlocks.Ddd.Domain/Entities/Full/FullEntity.cs
+14 −0 src/Ddd/Masa.BuildingBlocks.Ddd.Domain/Entities/Full/IFullAggregateRoot.cs
+14 −0 src/Ddd/Masa.BuildingBlocks.Ddd.Domain/Entities/Full/IFullEntity.cs
+2 −0 src/Ddd/Masa.BuildingBlocks.Ddd.Domain/_Imports.cs
40 changes: 27 additions & 13 deletions src/Data/Masa.Contrib.Data.EntityFrameworkCore/MasaDbContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,18 +101,32 @@ protected virtual void OnBeforeSaveChanges()
{
if (Options != null)
{
foreach (var filter in Options.SaveChangesFilters)
OnBeforeSaveChangesByFilters();
DomainEventEnqueueAsync(ChangeTracker).ConfigureAwait(false).GetAwaiter().GetResult();
}
}

protected virtual async Task OnBeforeSaveChangesAsync()
{
if (Options != null)
{
OnBeforeSaveChangesByFilters();
await DomainEventEnqueueAsync(ChangeTracker);
}
}

protected virtual void OnBeforeSaveChangesByFilters()
{
foreach (var filter in Options.SaveChangesFilters)
{
try
{
try
{
filter.OnExecuting(ChangeTracker);
}
catch (Exception ex)
{
throw new Exception("An error occured when intercept SaveChanges() or SaveChangesAsync()", ex);
}
filter.OnExecuting(ChangeTracker);
}
catch (Exception ex)
{
throw new Exception("An error occured when intercept SaveChanges() or SaveChangesAsync()", ex);
}
DomainEventEnqueueAsync(ChangeTracker).ConfigureAwait(false).GetAwaiter().GetResult();
}
}

Expand Down Expand Up @@ -151,10 +165,10 @@ protected virtual async Task DomainEventEnqueueAsync(ChangeTracker changeTracker
/// <param name="acceptAllChangesOnSuccess"></param>
/// <param name="cancellationToken"></param>
/// <returns></returns>
public sealed override Task<int> SaveChangesAsync(bool acceptAllChangesOnSuccess, CancellationToken cancellationToken = default)
public sealed override async Task<int> SaveChangesAsync(bool acceptAllChangesOnSuccess, CancellationToken cancellationToken = default)
{
OnBeforeSaveChanges();
return base.SaveChangesAsync(acceptAllChangesOnSuccess, cancellationToken);
await OnBeforeSaveChangesAsync();
return await base.SaveChangesAsync(acceptAllChangesOnSuccess, cancellationToken);
}
}

Expand Down