Feat:add a pure and cqrs template for masa framework #11

MapleWithoutWords · 2023-04-04T03:04:40Z

resolved #27

doddgu · 2023-04-04T05:35:53Z

MasaBp-Empty -> BlazorPure, 并且短名为 masab-pure
MasaFx-Service-Cqrs -> FrameworkServiceCqrs，短名为 masafxsp
MasaFx-Service -> FrameworkService，短名为 masafxs

doddgu · 2023-04-04T05:36:17Z

@zhenlei520 PTAL

src/Content/BlazorPure/src/BlazorPure.WebServer/Program.cs

src/Content/BlazorPure/src/BlazorPure.WebServer/_Imports.razor

src/Content/BlazorPure/src/BlazorPure.WebServer/wwwroot/css/site.css

src/Content/FrameworkService/Directory.Build.props

src/Content/FrameworkService/src/MasaFxService.Service/FrameworkService.Service.csproj

src/Content/FrameworkServiceCqrs/src/FrameworkServiceCqrs.Service/Program.cs

src/Content/FrameworkServiceCqrs/src/FrameworkServiceCqrs.Service/Services/ExampleService.cs

src/Content/FrameworkServiceCqrs/src/FrameworkServiceCqrs.Service/_Import.cs

capdiem · 2023-04-06T13:25:00Z

@MapleWithoutWords @doddgu

为什么不拆成三个PR？
官方BlazorServer Empty项目的短名称是 blazorserver-empty，建议一致。

src/Content/BlazorPure/.template.config/template.json

src/Content/BlazorPure/src/BlazorPure.WebServer/BlazorPure.WebServer.csproj

src/Content/BlazorPure/src/BlazorPure.WebServer/wwwroot/css/site.css

src/Content/BlazorPure/src/BlazorPure.WebServer/MainLayout.razor

capdiem · 2023-04-06T13:40:52Z

@MapleWithoutWords 建议你在 .NET7 的 BlazorServer Empty 模板上做修改，只需要增加必要的一些代码。

src/Content/BlazorPure/Directory.Build.props

src/Content/FrameworkService/.template.config/template.json

src/Content/FrameworkService/Directory.Build.props

src/Content/FrameworkService/src/MasaFxService.Service/FrameworkService.Service.csproj

src/Content/FrameworkService/src/MasaFxService.Service/Program.cs

...nt/FrameworkServiceCqrs/src/FrameworkServiceCqrs.Service/FrameworkServiceCqrs.Service.csproj

src/Content/FrameworkServiceCqrs/src/FrameworkServiceCqrs.Service/Program.cs

src/Content/FrameworkServiceCqrs/src/FrameworkServiceCqrs.Service/Services/readme.txt

src/Content/FrameworkServiceCqrs/src/FrameworkServiceCqrs.Service/_Import.cs

zhenlei520 · 2023-04-06T15:01:33Z

Issues that have been closed need to be rechecked to make sure they have been addressed @MapleWithoutWords

doddgu · 2023-04-10T06:10:00Z

@MapleWithoutWords @doddgu

为什么不拆成三个PR？

官方BlazorServer Empty项目的短名称是 blazorserver-empty，建议一致。

可以，那就保持一直吧。否则pro和pure都是p开头也容易混淆
@MapleWithoutWords

MapleWithoutWords · 2023-04-14T08:36:58Z

@MapleWithoutWords @doddgu

为什么不拆成三个PR？

官方BlazorServer Empty项目的短名称是 blazorserver-empty，建议一致。

可以，那就保持一直吧。否则pro和pure都是p开头也容易混淆 @MapleWithoutWords

跟官方保持一致，到时候名称会不会冲突，导致不显示?@doddgu @capdiem

zhenlei520 · 2023-04-14T08:44:23Z

跟官方保持一致，到时候名称会不会冲突，导致不显示?@doddgu @capdiem

前面加个masa？

MapleWithoutWords · 2023-04-14T08:51:08Z

我觉得，顺序要跟官方保持一致。官方名称叫：blazorserver-empty。我们就算在前面加masa，那也应该是：masablazor-server-emtpy才对。masablazor-empty-server这个名称感觉按照英文都不顺

doddgu · 2023-04-14T11:04:48Z

我觉得，顺序要跟官方保持一致。官方名称叫：blazorserver-empty。我们就算在前面加masa，那也应该是：masablazor-server-emtpy才对。masablazor-empty-server这个名称感觉按照英文都不顺

ok

zhenlei520 · 2023-04-18T08:39:35Z

MasaBp-Empty -> BlazorPure, 并且短名为 masab-pure MasaFx-Service-Cqrs -> FrameworkServiceCqrs，短名为 masafxsp MasaFx-Service -> FrameworkService，短名为 masafxs

masa framework 缩写为masafx没有问题，但模版名应该能反应其意图，否则这将不利于后期记忆

zhenlei520 · 2023-04-18T08:43:13Z

@MapleWithoutWords 应该有一个简易的图反应每个模版的作用以及对应的技术栈，新建一个issues并关联到当前的pr，确保后续追踪

zhenlei520

检查之前已经被关闭问题，重新再检查一遍

src/Content/FrameworkService/.template.config/dotnetcli.host.json

src/Content/FrameworkService/.template.config/ide.host.json

src/Content/FrameworkService/.template.config/template.json

src/Content/FrameworkServiceCqrs/src/FrameworkServiceCqrs.Service/Program.Main.cs

src/Content/FrameworkServiceCqrs/src/FrameworkServiceCqrs.Service/_Import.cs

src/Content/FrameworkServiceCqrs/src/FrameworkServiceCqrs.Service/Program.cs

...Content/FrameworkServiceCqrs/src/FrameworkServiceCqrs.Service/Properties/launchSettings.json

zhenlei520

LGTM @doddgu

src/Content/FrameworkService/Program.Main.cs

...erviceCqrs/src/MasaFrameworkServiceCqrs.Service/Application/Example/ExampleCommandHandler.cs

...iceCqrs/src/MasaFrameworkServiceCqrs.Service/DataAccess/MasaFrameworkServiceCqrsDbContext.cs

src/Content/FrameworkServiceCqrs/src/MasaFrameworkServiceCqrs.Service/Program.Main.cs

src/Content/FrameworkServiceCqrs/src/MasaFrameworkServiceCqrs.Service/Program.cs

src/Content/FrameworkServiceCqrs/src/MasaFrameworkServiceCqrs.Service/Program.Main.cs

MapleWithoutWords requested a review from doddgu April 4, 2023 03:04

doddgu requested a review from zhenlei520 April 4, 2023 05:36

zhenlei520 requested changes Apr 4, 2023

View reviewed changes

zhenlei520 self-requested a review April 6, 2023 07:54

MapleWithoutWords force-pushed the feat/add-pure-template branch from d501429 to 6b07bf6 Compare April 6, 2023 11:19

capdiem requested changes Apr 6, 2023

View reviewed changes

zhenlei520 requested changes Apr 6, 2023

View reviewed changes

MapleWithoutWords force-pushed the feat/add-pure-template branch from 8be9ea8 to 0a00967 Compare April 17, 2023 11:35

MapleWithoutWords requested review from zhenlei520 and capdiem April 17, 2023 11:43

MapleWithoutWords changed the title ~~Feat/add pure template~~ Feat:add a pure and cqrs template with masa framework Apr 18, 2023

MapleWithoutWords changed the title ~~Feat:add a pure and cqrs template with masa framework~~ Feat:add a pure and cqrs template for masa framework Apr 18, 2023

MapleWithoutWords mentioned this pull request Apr 18, 2023

feat: Masa Framework new Templates #27

Closed

2 tasks

zhenlei520 requested changes Apr 19, 2023

View reviewed changes

MapleWithoutWords force-pushed the feat/add-pure-template branch from dd36339 to f4d4201 Compare April 19, 2023 06:43

MapleWithoutWords requested a review from zhenlei520 April 19, 2023 06:55

MapleWithoutWords force-pushed the feat/add-pure-template branch from 25e332d to fdd8b8d Compare April 20, 2023 10:44

feat:framework service and cqrs template

c37d275

MapleWithoutWords force-pushed the feat/add-pure-template branch from fdd8b8d to c37d275 Compare April 20, 2023 10:45

MapleWithoutWords added 2 commits April 21, 2023 11:55

delete readme file

0b670c1

delete readme file

7b218b5

zhenlei520 approved these changes Apr 21, 2023

View reviewed changes

doddgu requested changes Apr 21, 2023

View reviewed changes

fix:code view problem

f786bd1

MapleWithoutWords requested a review from doddgu April 21, 2023 08:27

doddgu requested changes Apr 21, 2023

View reviewed changes

src/Content/FrameworkServiceCqrs/src/MasaFrameworkServiceCqrs.Service/Program.cs Outdated Show resolved Hide resolved

doddgu requested changes Apr 21, 2023

View reviewed changes

src/Content/FrameworkServiceCqrs/src/MasaFrameworkServiceCqrs.Service/Program.Main.cs Outdated Show resolved Hide resolved

src/Content/FrameworkServiceCqrs/src/MasaFrameworkServiceCqrs.Service/Program.Main.cs Outdated Show resolved Hide resolved

fix:code review problem

eff1e8d

MapleWithoutWords requested review from doddgu and zhenlei520 April 24, 2023 03:33

doddgu approved these changes Apr 24, 2023

View reviewed changes

doddgu merged commit dfc523e into main Apr 24, 2023

doddgu deleted the feat/add-pure-template branch April 24, 2023 06:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat:add a pure and cqrs template for masa framework #11

Feat:add a pure and cqrs template for masa framework #11

MapleWithoutWords commented Apr 4, 2023 •

edited

Loading

doddgu commented Apr 4, 2023

doddgu commented Apr 4, 2023

capdiem commented Apr 6, 2023

capdiem commented Apr 6, 2023

zhenlei520 commented Apr 6, 2023

doddgu commented Apr 10, 2023

MapleWithoutWords commented Apr 14, 2023

zhenlei520 commented Apr 14, 2023

MapleWithoutWords commented Apr 14, 2023

doddgu commented Apr 14, 2023

zhenlei520 commented Apr 18, 2023

zhenlei520 commented Apr 18, 2023

zhenlei520 left a comment

zhenlei520 left a comment •

edited

Loading

Feat:add a pure and cqrs template for masa framework #11

Feat:add a pure and cqrs template for masa framework #11

Conversation

MapleWithoutWords commented Apr 4, 2023 • edited Loading

doddgu commented Apr 4, 2023

doddgu commented Apr 4, 2023

capdiem commented Apr 6, 2023

capdiem commented Apr 6, 2023

zhenlei520 commented Apr 6, 2023

doddgu commented Apr 10, 2023

MapleWithoutWords commented Apr 14, 2023

zhenlei520 commented Apr 14, 2023

MapleWithoutWords commented Apr 14, 2023

doddgu commented Apr 14, 2023

zhenlei520 commented Apr 18, 2023

zhenlei520 commented Apr 18, 2023

zhenlei520 left a comment

Choose a reason for hiding this comment

zhenlei520 left a comment • edited Loading

Choose a reason for hiding this comment

MapleWithoutWords commented Apr 4, 2023 •

edited

Loading

zhenlei520 left a comment •

edited

Loading