Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a configuration option for spline interpolation style #479

Closed
rzds opened this issue Aug 5, 2014 · 7 comments
Closed

Add a configuration option for spline interpolation style #479

rzds opened this issue Aug 5, 2014 · 7 comments

Comments

@rzds
Copy link

rzds commented Aug 5, 2014

There's no value smaller than 0 and still the line goes under it. Any fixes for this ?
hh

@msisto
Copy link

msisto commented Aug 9, 2014

That is the nature of a spline chart (as opposed to a line chart), no? It's a bezier, so it interpolates or estimates the values between your data points.

@masayuki0812
Copy link
Member

Hi, I think @msisto is right. This is the nature of spline, so please use line chart if it's not good.

@mortenbo
Copy link

Sorry to comment on an closed issue but I was scratching my head over this as well.

I investigated the c3 code and saw that the method c3_chart_internal_fn.getInterpolate uses a cardinal interpolation option for splines. Would it make sense to use the monotone option instead or allow for customization to avoid forking the repo or overwriting the method?

See this for more information.

Thank you for an amazing library.

@aendra-rininsland
Copy link
Member

@mortenbo That's a good point; tbh, given spline doesn't have any configurable options, maybe it should be merged into the line chart and that chart style given a configurable interpolation option?

Reopening and renaming to better reflect issue.

@aendra-rininsland aendra-rininsland changed the title Spline Chart - Line goes under the minimum value Add a configuration option for spline interpolation style May 26, 2015
@mortenbo
Copy link

A configurable interpolation option would suit me very well.

@edmundoa
Copy link
Contributor

edmundoa commented Jul 2, 2015

Hi,

I am also interested in adding a configuration option to set the interpolation type in a spline, and willing to do a PR with the required changes. Reading this issue I assume you would like to have that option in the library, but I'm asking anyway :)

@mortenbo
Copy link

Awesome. Much appreciated :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants