Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve dispaching KeyboardEvent (for Speaker Deck) #3

Merged
merged 1 commit into from Jul 24, 2020
Merged

improve dispaching KeyboardEvent (for Speaker Deck) #3

merged 1 commit into from Jul 24, 2020

Conversation

mascii
Copy link
Owner

@mascii mascii commented Jul 24, 2020

Fix an error that was occurring on the slides page at https://speakerdeck.com/

> document.activeElement
<body class=​"sd-app">​…​</body>​

> document.dispatchEvent(new KeyboardEvent('keydown', {keyCode: 39}))
Uncaught TypeError: Cannot read property 'toLowerCase' of undefined
    at e.value (embed.js:122)
    at <anonymous>:1:10
value @ embed.js:122
(anonymous) @ VM89:1

@mascii mascii merged commit da83638 into master Jul 24, 2020
@mascii mascii deleted the hotfix/improve-dispatching-keyboard-event branch July 24, 2020 12:36
This was referenced Jul 24, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mascii