Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embed logger into context #8

Merged
merged 1 commit into from Oct 9, 2019

Conversation

@Songmu
Copy link
Contributor

commented Oct 8, 2019

We can't retrieve LoggingWriter from http.ResponseWriter, when the http.ResponseWriter is wrapped by another HTTP handler middleware even with the following code.

gz, ok := rw.(*accesslog.LoggingWriter)

It is difficult to get LoggingWriter from ResponseWriter accurately, so how about putting it in context?

@mash mash merged commit 4d68500 into mash:master Oct 9, 2019
@mash

This comment has been minimized.

Copy link
Owner

commented Oct 9, 2019

👍

@Songmu

This comment has been minimized.

Copy link
Contributor Author

commented Oct 10, 2019

Thank you for the guick merge. Could you tag semver for go modules? I want to use it in production immediately.

@Songmu Songmu deleted the Songmu:embed-logger-into-context branch Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.