Basic authorization #63

Closed
wants to merge 3 commits into
from

Projects

None yet

7 participants

@marcin-wosinek

I've merged @gkostov commit 3927c97 mentioned in issue #10 to current master; and hide password.

@mansilladev
Contributor

Marcin, I've tested out your code and it works swell. Before I merge in, I'd like to propose that we slightly modify the JSON configuration schema to support multiple authentication mechanisms -- so that both HTTP Basic auth and API key authorization is supported on the same API. For example:

{
    "yourAPI": {
        "name":"Your API",
        "protocol": "http",
        "auth": {
            "key": {
                "keyParam": "api_key",
                "signature": {
                    "type": "signed_md5",
                    "sigParam": "sig",
                    "digest": "hex"  
                }
            },
            "basic": {}
        }
    }
}

I have run into APIs that require both an API key and HTTP basic auth. Does anyone have any thoughts they'd like to add to this before I start coding?

@marcin-wosinek

Sounds reasonable for me

@jedwood
Contributor
jedwood commented Mar 22, 2013

Any word on this? It'd be great to have Basic Auth built-in.

@lazutkin
Contributor

+1

@lazutkin
Contributor

Guys! Please merge it in.

@mansilladev
Contributor

Looking back, there was a big schema change to accommodate simul. apiKey+basic auth. Will revisit soon. Thanks for ping.

@mansilladev mansilladev added the auth label Mar 28, 2014
@egeek egeek referenced this pull request Apr 2, 2014
Closed

Updated BASIC AUTH support #172

@mansilladev
Contributor

Basic auth feature added for both Node server level and API request level.

@mansilladev mansilladev closed this Oct 7, 2014
@phairow phairow referenced this pull request Oct 10, 2014
Closed

Add HTTP Basic Auth Type #10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment