Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YAML support #341

Closed
wants to merge 8 commits into from
Closed

YAML support #341

wants to merge 8 commits into from

Conversation

jun85664396
Copy link

@jun85664396 jun85664396 commented Nov 4, 2017

Hello,

This code is similar a pull request (#79)

  • YAML support
  • Fix deprecated API DEP0016
  • Add YAML locales files

As pull request I mentioned was not updated, I make a new pull request.

  • @TheRusskiy Hello, I make a new pull request Cause you didn’t update pull request.
    Thank you

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 97.947% when pulling 81b6285 on jun85664396:master into d54e465 on mashpie:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 97.947% when pulling 81b6285 on jun85664396:master into d54e465 on mashpie:master.

@coveralls
Copy link

coveralls commented Nov 6, 2017

Coverage Status

Coverage increased (+0.04%) to 97.947% when pulling 81b6285 on jun85664396:master into d54e465 on mashpie:master.

@coveralls
Copy link

coveralls commented Nov 6, 2017

Coverage Status

Coverage increased (+0.04%) to 97.947% when pulling 2bbb346 on jun85664396:master into d54e465 on mashpie:master.

@coveralls
Copy link

coveralls commented Nov 6, 2017

Coverage Status

Coverage increased (+0.04%) to 97.947% when pulling d34a696 on jun85664396:master into d54e465 on mashpie:master.

@coveralls
Copy link

coveralls commented Nov 7, 2017

Coverage Status

Coverage increased (+0.04%) to 97.947% when pulling ca1d7f5 on jun85664396:master into d54e465 on mashpie:master.

1 similar comment
@coveralls
Copy link

coveralls commented Nov 7, 2017

Coverage Status

Coverage increased (+0.04%) to 97.947% when pulling ca1d7f5 on jun85664396:master into d54e465 on mashpie:master.

@ianwalter
Copy link

Just wanted to mention that I tried this fork out last night and seems to be working as expected. Let me know if I can do anything else to help. Thank you.

@mrtndwrd
Copy link

Hi, any chance this will be merged? The PR has been open for over a year

@mashpie mashpie added the project tracked in a project label Aug 18, 2020
@mashpie
Copy link
Owner

mashpie commented Aug 18, 2020

yaml - or whatever non-native format will get supported by explicit storage adapter, after introducing a storage interface. Currently there is no single yaml package available which didn't introduce some kind of vulnerability - that is one reason I want to keep it away from core. Another is, hey it's more than simple transcoding json <-> yaml within any kind of workflow or directly in your editor / IDE.

Right now anyone may use any kind of own reader by using staticCatalog, see https://github.com/mashpie/i18n-node#some-words-on-staticcatalog-option - but that is read-only, plan is to support multiple formats & sources as read/write

Will keep as todo for refactored backend project.

@mashpie mashpie closed this Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project tracked in a project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants