New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to fix inconsistent terminology #17

Closed
veebs opened this Issue Jun 1, 2012 · 0 comments

Comments

Projects
None yet
1 participant
@veebs
Copy link
Member

veebs commented Jun 1, 2012

Packages

  • utils to infrastructure
  • context to events
  • processors to handlers

Rename context class to match Route extractors

  • HttpRequestProcessingContext > HttpRequestEvent
  • HttpChunkProcessingContext > HttpRequestEvent
  • WsFrameProcessingContext > WebSocketFrameEvent
  • WsHandshakeProcessingContext > WebSocketHandshakeEvent

Web Socket authorization
The isAllowed flag is not intuitive. authorize makes more sense.

  • OLD: WsHandshakeProcessingContext.isAllow = true
  • NEW: WebSocketHandshakeEvent.authorize()

Reading and Writing HTTP responses

  • Rather than mixing request and response variables and methods in the context, separate then into request and response.
  • HttpRequestProcessingContext.writeResponse(), HttpRequestProcessingContext .writeErrorResponse(), HttpRequestProcessingContext.writeBinaryResponse() > HttpRequestEvent.response.write()

Reading and Writing web sockets

  • readBinaryData() > readBinary()
  • writeBinaryData() > writeBinary()

@ghost ghost assigned veebs Jun 1, 2012

veebs added a commit that referenced this issue Jun 1, 2012

veebs added a commit that referenced this issue Jun 1, 2012

@veebs veebs closed this Jun 2, 2012

veebs added a commit that referenced this issue Jun 3, 2012

veebs added a commit that referenced this issue Jun 3, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment