Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace novoda/bintray-release with bintray/gradle-bintray-plugin #461

Merged
merged 5 commits into from Oct 18, 2018

Conversation

@chibatching
Copy link
Contributor

@chibatching chibatching commented Oct 17, 2018

Replace novoda/bintray-release with bintray official bintray/gradle-bintray-plugin to get rid of blocker of #448.

I can't test upload because I don't know the credentials, but you can check generated artifacts and pom.

Execute

./gradlew clean install

And please verify the files at $HOME/.m2/repository/com/github/maskarade/android/orma uploaded to bintray.

@@ -1,5 +1,4 @@
apply plugin: 'java'
apply plugin: 'com.novoda.bintray-release'

This comment has been minimized.

@k-kagurazaka

k-kagurazaka Oct 17, 2018
Member

Is apply plugin: 'com.github.dcendents.android-maven' not needed?
Others build.gradle has the line.

This comment has been minimized.

@chibatching

chibatching Oct 17, 2018
Author Contributor

This module and processor module is not android project.
So, we don't need this plugin.

This comment has been minimized.

@k-kagurazaka

k-kagurazaka Oct 18, 2018
Member

I just understand, thanks!

This comment has been minimized.

@gfx

gfx Oct 18, 2018
Member

👍

}
developers {
developer metadata.developer
}

This comment has been minimized.

@chibatching

chibatching Oct 18, 2018
Author Contributor

Some metadata is not contained in the original POM file, but sometimes it is useful for example license tools.
If we don't need this, I'll remove these.

This comment has been minimized.

@gfx

gfx Oct 18, 2018
Member

🆒


bintray {
//TODO Set appropriate authorize information
user = "foo"

This comment has been minimized.

@gfx

gfx Oct 18, 2018
Member

Use ext.bintrayUser, which should be defined in ~/.gradle/gradle.properties.

bintray {
//TODO Set appropriate authorize information
user = "foo"
key = "bar"

This comment has been minimized.

@gfx

gfx Oct 18, 2018
Member

Use ext.bintrayKey, which should be defined in ~/.gradle/gradle.properties, too.

This comment has been minimized.

@chibatching

chibatching Oct 18, 2018
Author Contributor

Fixed at da5acf2 😄

@gfx
Copy link
Member

@gfx gfx commented Oct 18, 2018

Coooool!! ㊗️

I'll merge it soon after user and key are fixed.

@chibatching
Copy link
Contributor Author

@chibatching chibatching commented Oct 18, 2018

I am worried about the uploadBintray task deploying appropriate bintray packages.

This PR is created based on My library has multi-module like orma but it is deployed the single bintray package and multi artifacts.

Android-Orma has the multi bintray package and single artifact per package.
So, I set name and desc per module (), but I can't confirm this works right. 😭

@chibatching
Copy link
Contributor Author

@chibatching chibatching commented Oct 18, 2018

CI failed with Cannot get property 'bintrayKey' on extra properties extension as it does not exist 😢

@k-kagurazaka
Copy link
Member

@k-kagurazaka k-kagurazaka commented Oct 18, 2018

Properties in ~/.gradle/gradle.properties cannot be accessed by ext.
Please use user = property('bintrayUser') format.

@chibatching chibatching force-pushed the chibatching:replace_bintray_plugin branch from dc5ab2e to da5acf2 Oct 18, 2018
@k-kagurazaka
Copy link
Member

@k-kagurazaka k-kagurazaka commented Oct 18, 2018

Sorry for my wrong knowledge 🙇
Build is still failed 😭

@k-kagurazaka
Copy link
Member

@k-kagurazaka k-kagurazaka commented Oct 18, 2018

@gfx Does Circle CI have credentials?
In my understand, Circle CI do build but doesn't publish artifacts until now.

@chibatching
Copy link
Contributor Author

@chibatching chibatching commented Oct 18, 2018

Some value needs on Gradle configuration phase, so I'll set dummy value if the property does not exist.

@chibatching
Copy link
Contributor Author

@chibatching chibatching commented Oct 18, 2018

Pass!!

@chibatching
Copy link
Contributor Author

@chibatching chibatching commented Oct 18, 2018

I misunderstand the behavior. Right behavior is below.

  1. Bintray closure is executed on the configuration phase.
  2. property(String name) method is executed, and throw MissingPropertyException if property doesn't exist.
  3. Crash!

So, I change method findProperty(String name), it returns null if property doesn't exist.

@gfx
Copy link
Member

@gfx gfx commented Oct 18, 2018

LGTM! Thanks for the effort!

@gfx gfx merged commit f5833a4 into maskarade:master Oct 18, 2018
1 check passed
1 check passed
ci/circleci Your tests passed on CircleCI!
Details
@chibatching chibatching deleted the chibatching:replace_bintray_plugin branch Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants