Removing eval from bundle to avoid strict CSP issues #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
This looks reasonable, thanks for submitting this 👍 |
Owner
|
Published as v2.6 - let me know if it works. |
Contributor
Author
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The browser single bundle contained eval coming from webpack & babel polyfills which are violating strict CSP policies. Reducing these policies is a significant security risk for our business. Here are the recommendations to solve this issue, which are what I've implemented here.
I've only implemented this for browser-single, since that is what our team is using.
Discussion: webpack/webpack#5627
Solution within discussion: webpack/webpack#5627 (comment)
More on the topic from famous Mathias: https://mathiasbynens.be/notes/globalthis