optimize number serializers#96
Merged
Merged
Conversation
Thykof
suggested changes
Feb 6, 2023
peterjah
force-pushed
the
serializer_optim
branch
from
61bcb9c to
178cc01
Compare
Thykof
approved these changes
Feb 6, 2023
gregLibert
approved these changes
Feb 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Benchmark
For 1 Million serialize/deserialize:
with u32
old version: 416.561ms
new version: 296.325ms
gain: 28.8%
with u64
old version: 515.476ms
new version: 305.632ms
gain: 40.7%
with f64
old version: 492.263ms
new version: 321.706ms
gain: 34.7%