Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #1277: make PROTOCOL related config const or static ref frozen in binary rather than loaded from config.toml #1848

Merged
merged 1 commit into from Dec 8, 2021
Merged

Fix issue #1277: make PROTOCOL related config const or static ref frozen in binary rather than loaded from config.toml #1848

merged 1 commit into from Dec 8, 2021

Conversation

yvan-sraka
Copy link
Contributor

@yvan-sraka yvan-sraka commented Nov 23, 2021 •
edited

The nice side effect of this issue is that it helps to easily get rid of SerializationContext :)

@yvan-sraka yvan-sraka self-assigned this Nov 23, 2021
@yvan-sraka yvan-sraka force-pushed the protocol-config-const-in-binary branch 2 times, most recently from feee270 to 706960b Compare November 23, 2021 20:23
AureliaDolo
AureliaDolo reviewed Nov 25, 2021
View reviewed changes
Copy link
Contributor

@AureliaDolo AureliaDolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We mus be able to override the config in the tests, especially the consensus ones.

@yvan-sraka yvan-sraka force-pushed the protocol-config-const-in-binary branch from 706960b to 3d439e1 Compare November 25, 2021 11:37
@yvan-sraka yvan-sraka changed the title Fix issue #1277: make PROTOCOL related config const or static ref in binary rather than loaded from config.toml Fix issue #1277: make PROTOCOL related config const or static ref frozen in binary rather than loaded from config.toml Nov 25, 2021
@yvan-sraka yvan-sraka force-pushed the protocol-config-const-in-binary branch from 3d439e1 to ac6386d Compare November 25, 2021 19:10
@yvan-sraka yvan-sraka force-pushed the protocol-config-const-in-binary branch from ac6386d to 5e82a13 Compare November 25, 2021 19:37
AureliaDolo
AureliaDolo previously approved these changes Nov 26, 2021
View reviewed changes
@yvan-sraka yvan-sraka force-pushed the protocol-config-const-in-binary branch from 5e82a13 to 707c253 Compare November 26, 2021 09:54
@yvan-sraka yvan-sraka force-pushed the protocol-config-const-in-binary branch 2 times, most recently from b28a430 to b5e2183 Compare November 29, 2021 08:30
@yvan-sraka yvan-sraka mentioned this pull request Dec 2, 2021
Merged
@yvan-sraka yvan-sraka linked an issue Dec 6, 2021 that may be closed by this pull request
Make PROTOCOL related config const or static ref in binary rather than loaded from config.toml #1277
Closed
@yvan-sraka yvan-sraka mentioned this pull request Dec 6, 2021
Closed
@yvan-sraka yvan-sraka force-pushed the protocol-config-const-in-binary branch from b5e2183 to 5c299ee Compare December 6, 2021 22:07
@yvan-sraka yvan-sraka mentioned this pull request Dec 6, 2021
Merged
AureliaDolo
AureliaDolo reviewed Dec 7, 2021
View reviewed changes
Copy link
Contributor

@AureliaDolo AureliaDolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you decided what modification in the test to remove ?

@yvan-sraka yvan-sraka force-pushed the protocol-config-const-in-binary branch from 5c299ee to 5221070 Compare December 7, 2021 10:22
@AureliaDolo AureliaDolo self-requested a review December 7, 2021 10:27
AureliaDolo
AureliaDolo previously approved these changes Dec 7, 2021
View reviewed changes
@AureliaDolo
Copy link
Contributor

bors merge

@yvan-sraka yvan-sraka force-pushed the protocol-config-const-in-binary branch from 45791d0 to d21c0bb Compare December 7, 2021 15:06
@AureliaDolo AureliaDolo self-requested a review December 7, 2021 15:08
AureliaDolo
AureliaDolo previously approved these changes Dec 7, 2021
View reviewed changes
@massalabs massalabs deleted a comment from AureliaDolo Dec 7, 2021
@yvan-sraka
Copy link
Contributor Author

bors merge

bors bot added a commit that referenced this pull request Dec 7, 2021
@bors @yvan-sraka
Merge #1848
553d4ae 
1848: Fix issue #1277: make PROTOCOL related config `const` or `static ref` frozen in binary rather than loaded from `config.toml` r=yvan-sraka a=yvan-sraka

The nice side effect of this issue is that it helps to easily get rid of `SerializationContext` :)

Co-authored-by: Yvan Sraka <yvan@sraka.xyz>
@bors
Copy link
Contributor

bors bot commented Dec 7, 2021

Build failed:

@yvan-sraka yvan-sraka force-pushed the protocol-config-const-in-binary branch from d21c0bb to 366e32f Compare December 7, 2021 16:42
AureliaDolo
AureliaDolo previously approved these changes Dec 7, 2021
View reviewed changes
@AureliaDolo
Copy link
Contributor

bors merge

bors bot added a commit that referenced this pull request Dec 7, 2021
@bors @yvan-sraka
Merge #1848
9eefb16 
1848: Fix issue #1277: make PROTOCOL related config `const` or `static ref` frozen in binary rather than loaded from `config.toml` r=AureliaDolo a=yvan-sraka

The nice side effect of this issue is that it helps to easily get rid of `SerializationContext` :)

Co-authored-by: Yvan Sraka <yvan@sraka.xyz>
@bors
Copy link
Contributor

bors bot commented Dec 7, 2021

Build failed:

@yvan-sraka yvan-sraka force-pushed the protocol-config-const-in-binary branch from 366e32f to 38b4127 Compare December 7, 2021 17:26
adrien-zinger
adrien-zinger previously approved these changes Dec 7, 2021
View reviewed changes
consensus/src/settings.rs Outdated Show resolved Hide resolved
massa-node/src/main.rs Show resolved Hide resolved
@yvan-sraka yvan-sraka force-pushed the protocol-config-const-in-binary branch 2 times, most recently from f1f067a to 2c6654a Compare December 8, 2021 09:39
@yvan-sraka
Fix issue #1277: make PROTOCOL related config const
2a77957 
or static ref frozen in binary rather than loaded from config.toml
@yvan-sraka yvan-sraka force-pushed the protocol-config-const-in-binary branch from 2c6654a to 2a77957 Compare December 8, 2021 09:45
@AureliaDolo
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Dec 8, 2021

Build succeeded:

@bors bors bot merged commit fba878c into main Dec 8, 2021
@bors bors bot deleted the protocol-config-const-in-binary branch December 8, 2021 10:13
@AureliaDolo AureliaDolo mentioned this pull request Dec 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AureliaDolo AureliaDolo AureliaDolo approved these changes

@damip damip Awaiting requested review from damip

@gterzian gterzian Awaiting requested review from gterzian

@adrien-zinger adrien-zinger Awaiting requested review from adrien-zinger

Assignees

@yvan-sraka yvan-sraka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make PROTOCOL related config const or static ref in binary rather than loaded from config.toml
3 participants
@yvan-sraka @AureliaDolo @adrien-zinger