redbug_dtop: fix handling of -0.0 for OTP-26.1/27.0 #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matching of floating-point zeroes will change in OTP-27 so that -0.0 will no longer match a non-negative 0.0. OTP-26.1 warns about such constructs, which in redbug results in: ===> Compiling src/redbug_dtop.erl failed src/redbug_dtop.erl:225:9: matching on the float 0.0 will no longer also match -0.0 in OTP 27. If you specifically intend to match 0.0 alone, write +0.0 instead. Fixed by switching from a match to a numerical comparison.
|
👋 @massemanet, any chance this gets merged+released soonish, 🥺? Thanks. |
|
In the meantime, as a workaround, those stumbling upon this can use (in e.g. {overrides, [
{add, redbug, [{erl_opts, [nowarn_match_float_zero]}]}
]}. |
|
I'm on it!
…On Wed, Sep 27, 2023, 13:34 Paulo F. Oliveira ***@***.***> wrote:
In the meantime, as a workaround, those stumbling upon this can use (in
e.g. rebar.config)
{overrides, [
{add, redbug, [{erl_opts, [nowarn_match_float_zero]}]}
]}.
—
Reply to this email directly, view it on GitHub
<#34 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAADDBU4FAOQESPA3CRJXM3X4QFLRANCNFSM6AAAAAA5DCNFZE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@massemanet, what would be required for this get reviewed, approved, merged and tagged/released? Willing to help in any of the stages, just let me know. Thanks. |
massemanet
approved these changes
Nov 27, 2023
|
apologies for missing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matching of floating-point zeroes will change in OTP-27 so that -0.0 will no longer match a non-negative 0.0. OTP-26.1 warns about such constructs, which in redbug results in:
===> Compiling src/redbug_dtop.erl failed
src/redbug_dtop.erl:225:9: matching on the float 0.0 will no longer also match -0.0 in OTP 27. If you specifically intend to match 0.0 alone, write +0.0 instead.
Fixed by switching from a match to a numerical comparison.