Skip to content

Commit 1966c48

Browse files
committed
Added fix for unsafe unserialization reported by @mcdruid
1 parent dfa8e3d commit 1966c48

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

docroot/modules/custom/mass_entityreference/src/Plugin/EntityReferenceSelection/MassFilterEntitiesSelection.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ protected function buildEntityQuery($match = NULL, $match_operator = 'CONTAINS')
2828
// Get the users selected filter.
2929
$cookie = \Drupal::requestStack()->getCurrentRequest()->cookies->get('Drupal_visitor_autocomplete_select_filter');
3030
if (!empty($cookie)) {
31-
$types = unserialize($cookie);
31+
$types = json_decode($cookie);
3232
}
3333

3434
$query = $this->entityTypeManager->getStorage($target_type)->getQuery()->accessCheck();

docroot/modules/custom/mass_entityreference/src/Plugin/Field/FieldWidget/EntityReferenceSelectAutocompleteWidget.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ public function form(FieldItemListInterface $items, array &$form, FormStateInter
5959
*/
6060
public static function setFilterSelect(array $form, FormStateInterface $form_state) {
6161
$select = $form_state->getTriggeringElement();
62-
user_cookie_save(['autocomplete_select_filter' => serialize($select['#value'])]);
62+
user_cookie_save(['autocomplete_select_filter' => json_encode($select['#value'])]);
6363
return new AjaxResponse();
6464
}
6565

0 commit comments

Comments
 (0)