Skip to content

Changes to RunCommand to make running tests on Linux more effective#21

Merged
misprintt merged 1 commit into
massive-oss:masterfrom
jasononeil:master
May 9, 2012
Merged

Changes to RunCommand to make running tests on Linux more effective#21
misprintt merged 1 commit into
massive-oss:masterfrom
jasononeil:master

Conversation

@jasononeil

Copy link
Copy Markdown
Contributor

This pull request is dependent on this one in MassiveLib:
massive-oss/mlib#2

I've made only two small changes

  • Change "tmp" directory to be created in local folder, not haxelib folder. This fixes a permissions issue on linux (see Fail to run tests as non-priveleged user on Linux #18)
  • Change the launchFile() method to support linux browser launches. By default they use "xdg-open", unless "browser" is specified in the run command, in which case, use that browser and pass the URL as the first parameter. This should give the user their default browser for most modern linux distributions.

 - change tmp/ to resolve from the user's project dir, not the haxelib dir
   (to fix permissions issues, see massive-oss#18)
 - change browser launch to support linux commands
    - `use xdg-open` if no browser is specified.  Should use user's default browser on most systems.
    - if browser is specified, use that and pass URL as first parameter
@jasononeil

Copy link
Copy Markdown
Contributor Author

The pull request for MassiveLib has been merged, (massive-oss/mlib#2) so this should work now. Though I hear you guys are working on a new version anyway, so not sure if this is needed :)

misprintt added a commit that referenced this pull request May 9, 2012
Changes to RunCommand to make running tests on Linux more effective
@misprintt misprintt merged commit 913f8b7 into massive-oss:master May 9, 2012
@misprintt

Copy link
Copy Markdown
Contributor

Hi Jason.

Apologies - this dropped off the radar around easter! Can you please test 0.9.2.4 to confirm all good on linux.

I've modified your pull request slightly to enable the localhost server to function correctly. It now creates a symbolic link to the original server neko file in the working directory (which i moved inside the local project bin directory as well)

@jasononeil

Copy link
Copy Markdown
Contributor Author

Hi

I can confirm that now the default browser opens on linux. Also the
-browser argument works too. Thanks for this, it is much easier.

Are results of these tests supposed to be reported back to the command
line? Currently the command line shows the results for neko, then opens
the browser (and you can see the results there) but the terminal eventually
prints:

ERROR: Local results server appeared to hang so test reporting was

cancelled.

I imagine this is not the expected behaviour? I suppose that's another
issue that I should attempt to debug elsewhere. Either way, thanks for
accepting this pull request, very helpful.

Jason

On Wed, May 9, 2012 at 12:42 PM, Dominic De Lorenzo <
reply@reply.github.com

wrote:

Hi Jason.

Apologies - this dropped off the radar around easter! Can you please test
0.9.2.4 to confirm all good on linux.

I've modified your pull request slightly to enable the localhost server to
function correctly. It now creates a symbolic link to the original server
neko file in the working directory (which i moved inside the local project
bin directory as well)


Reply to this email directly or view it on GitHub:

#21 (comment)

@misprintt

Copy link
Copy Markdown
Contributor

Hi Jason,

That's probably due to 'nekotools server' not finding the reference to bin/index.n

I had implemented it as a symbolic link for osx and linux. I've changed it back to a simple file copy which should be much safer.

Pushed out as 0.9.2.5

@jasononeil

Copy link
Copy Markdown
Contributor Author

Hmm the behaviour still seems the same (timing out, no response)

I might dig around when I get home see if I can figure it out. Thanks for
your help on this. For my personal use I consider this easily functional
enough :)

On Thu, May 10, 2012 at 11:17 AM, Dominic De Lorenzo <
reply@reply.github.com

wrote:

Hi Jason,

That's probably due to 'nekotools server' not finding the reference to
bin/index.n

I had implemented it as a symbolic link for osx and linux. I've changed it
back to a simple file copy which should be much safer.

Pushed out as 0.9.2.5


Reply to this email directly or view it on GitHub:

#21 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants