Better UI/UX for suggestions for new users (IOS-157) #1044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimar
reviewed
May 16, 2023
Mastodon/Scene/SuggestionAccount/TableViewCell/SuggestionAccountTableViewCell+ViewModel.swift
Outdated
Show resolved
Hide resolved
Mastodon/Scene/SuggestionAccount/TableViewCell/SuggestionAccountTableViewCell+ViewModel.swift
Outdated
Show resolved
Hide resolved
kimar
reviewed
May 17, 2023
Mastodon/Scene/Share/View/TableviewCell/UserTableViewCell+ViewModel.swift
Show resolved
Hide resolved
kimar
reviewed
May 17, 2023
zeitschlag
force-pushed
the
ios-157-popular-on-mastodon
branch
from
67eb792 to
7a74cae
Compare
Make avatar-image bigger, fix position of follow-button
- Also: Rename folder as this contains not only the cell anymore - This is just UI, follow-function is still missing
- NavigationBar - ContentInset for TableView
The secret is to set the delegate before getting the account. This doesn't feel right.
We need this viewModel for the button--state of the follow-button. There's still a runtime-issue that resets the button-state to follow.
Thanks to @kimar for pointing this out!
Reason for button-state not working/updating feels like to be a weird combination of Combine, UIKit, Snapshots, CoreData and me being stupid and not getting a hang on it.
aka when account-suggestion-screen
Follow-button wasn't attached to the right side
Wasn't tappable on iPhone
zeitschlag
force-pushed
the
ios-157-popular-on-mastodon
branch
from
124cb82 to
8b7e491
Compare
kimar
approved these changes
May 25, 2023
Mastodon/Scene/SuggestionAccount/SuggestionAccountViewController.swift
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Say hello to the new "Hey, do you already follow there people?"-screen, that appears every time you open the app and don't follow people. And when you press the "Find people to follow"-button on the empty-screen
It uses the new
UserViewfor every account, but offers the option to follow them all.