Better Search Workflow (IOS-141) #1115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeitschlag
changed the title
Also: Move stuff around. It doesn't make sense for search-diffable-stuff to live in an enitrely different folder than the rest.
Shame on me for such a big commit. I'm new to iOS-development, sorry :nerd:
It's either a profile (then show the profile) or a status (than show the status) or a link (then open the link in safari)
zeitschlag
changed the title
kimar
approved these changes
Sep 20, 2023
There was a problem hiding this comment.
Looks really great @zeitschlag just one tiny thing which, when using "Posts matching XYZ" (or People matching XYZ) there is a certain delay between showing the view and when the activity indicator appears. In the first place to me this looked like there were no results and I just saw an empty screen. Maybe we can show the activity indicator immediate once the screen is show but has no results yet?
Mastodon/Protocol/Provider/DataSourceFacade+SearchHistory.swift
Outdated
Show resolved
Hide resolved
aaaaand simplify things as we don't need a super-dynamic search-result-screen anymore.
Well, okay, `ViewControllerWithDependencies` not super creative.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We improved the Search Flow and were inspired by the amazing Ivory.
Search History looks like this now:
It features a condensed version of the
UserView.When you search for things, there are two groups now. The upper one offers some handy shortcuts, while the lower group suggests up to three hashtags and up to three users:
If you paste a link into the hashtag, another elements becomes visible:
When this links leads to a status or user, you can see them directly inside the app. Oh, and we added some error-handling, too. Let's say, the user you're looking for doesn't exist, then alert tells you so:
But wait, that's not all! You can search for users on other servers, too. Just enter their handle...
... and the "Go to..."-option shows the way to them right away :)