Use Keychain for credentials #1131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a lot of warnings in Console when searching for a server
🤦 Co-authored-by: Marcus Kida <marcus.kida@bearologics.com>
Authentication Migrations
zeitschlag
force-pushed
the
move-credentials-to-keychain
branch
from
ff15093 to
6df7cf8
Compare
kimar
approved these changes
Oct 12, 2023
There was a problem hiding this comment.
👍 This is really nice and works as expected for me, tested the following scenarios:
- Installed current App Store with Logged in Accounts
- Installed this PR build -> Migrated as expected
- Uninstalled App
- Installed App Store build -> Asked to sign in
- Uninstalled App Store build
- Installed this PR build -> Instant sign in due to credentials being persisted in Keychain
LGTM to me 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
performance_experiments-branch, but with CoreData on disk instead of in memory and with the most recentdevelopmerged.UserDefaultsif migration was successful)Side Effects