Don't persist translations #1135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I want to add two more things:
Thank you @grishka! |
kimar
approved these changes
Oct 17, 2023
|
@kimar Thank you very much! Even though you already approved this pr, may I ask you for another short review of the last two commits? |
kimar
approved these changes
Oct 18, 2023
|
@zeitschlag Works for me now 👍 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aka. Don't use CoreData for translations.
We don't need to persist translations. They're temporary nevertheless.
This is basically my starting point for the CoreData-removal. Instead of ripping out something big, I decided to replace one property. I didn't feel confident to remove this property on a branch that doesn't build, that's why I chose
develop. Being able to build and run to see if I may have broken the functionality helped me a lot.