Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Deplyment Target to iOS 15 #783

Merged
merged 4 commits into from
Dec 22, 2022
Merged

Bump Deplyment Target to iOS 15 #783

merged 4 commits into from
Dec 22, 2022

Conversation

zeitschlag
Copy link
Contributor

No description provided.

@j-f1
Copy link
Contributor

j-f1 commented Dec 17, 2022

Also, are you working on handling the deprecation warnings? I can take a look at those if you’re not!

@zeitschlag
Copy link
Contributor Author

zeitschlag commented Dec 17, 2022 •
edited
Loading

@j-f1 Good point. If you see something, feel free to fix it :) I'll do so myself, too. Thanks for you help!

From what I see, most warnings are 'contentEdgeInsets' was deprecated in iOS 15.0: This property is ignored when using UIButtonConfiguration, but we don't use configurations (yet)

@zeitschlag zeitschlag changed the title Bump to iOS 15 deployment target Bump Deplyment Target to iOS 15 Dec 17, 2022
j-f1
j-f1 approved these changes Dec 18, 2022
View reviewed changes
Copy link
Contributor

@j-f1 j-f1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

sladewatkins
sladewatkins approved these changes Dec 18, 2022
View reviewed changes
Copy link

@sladewatkins sladewatkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well!

kimar
kimar approved these changes Dec 22, 2022
View reviewed changes
Copy link
Contributor

@kimar kimar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zeitschlag zeitschlag added this to the 1.4.10 milestone Dec 22, 2022
@zeitschlag zeitschlag merged commit 3e2282c into develop Dec 22, 2022
@zeitschlag zeitschlag deleted the ios_15 branch December 28, 2022 14:54
@j-f1 j-f1 mentioned this pull request Jan 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimar kimar kimar approved these changes

@sladewatkins sladewatkins sladewatkins approved these changes

@j-f1 j-f1 j-f1 approved these changes

@MainasuK MainasuK Awaiting requested review from MainasuK

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4.10
Development

Successfully merging this pull request may close these issues.
4 participants
@zeitschlag @j-f1 @kimar @sladewatkins