-
-
Notifications
You must be signed in to change notification settings - Fork 292
Implement post editing / edit history #875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
52ba98a
to
d98d5b4
Compare
b503814
to
803d075
Compare
e1cff54
to
0e63509
Compare
MastodonSDK/Sources/CoreDataStack/CoreData.xcdatamodeld/CoreData 9.xcdatamodel/contents
Outdated
Show resolved
Hide resolved
Since presumably only you and a couple of people ever installed an app using CoreData 8, would it be possible to make the changes to CoreData 8 directly instead of making a new version? (I think it’s also fine to change the optional status of a field without making a new version) |
@j-f1 I was also considering this, I'll make the changes t model v8 directly then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome! I opened #951 with a few improvements; namely, attempting to emulate the styling of table view cells for StatusMetricRowView
, improving display at large text sizes, and improving VoiceOver accessibility. It’s not currently possible to access the edit history via VoiceOver (underlying issue for that is IOS-70 which I will try to handle today or tomorrow).
9e2f5de
to
8b0cc76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the stuff looks good to me, although I'm a bit uncertain about Persistence+StatusEdit.swift
.
Mastodon/Scene/Thread/Edit History/StatusEditHistoryTableViewCell.swift
Outdated
Show resolved
Hide resolved
Mastodon/Scene/Thread/Edit History/StatusEditHistoryTableViewCell.swift
Outdated
Show resolved
Hide resolved
Mastodon/Scene/Thread/Edit History/StatusEditHistoryViewController.swift
Show resolved
Hide resolved
Mastodon/Scene/Thread/Edit History/StatusEditHistoryViewController.swift
Show resolved
Hide resolved
MastodonSDK/Sources/MastodonCore/Extension/CoreDataStack/StatusEdit+Property.swift
Outdated
Show resolved
Hide resolved
MastodonSDK/Sources/MastodonCore/Persistence/Persistence+StatusEdit.swift
Outdated
Show resolved
Hide resolved
MastodonSDK/Sources/MastodonUI/View/Content/StatusMetricRowView.swift
Outdated
Show resolved
Hide resolved
6d1a78a
to
ece2314
Compare
This reverts commit 753e2ca.
Co-authored-by: Jed Fox <git@jedfox.com>
Co-authored-by: Jed Fox <git@jedfox.com>
ece2314
to
a35556a
Compare
Rationale