Skip to content

Implement post editing / edit history #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 80 commits into from
Mar 2, 2023
Merged

Implement post editing / edit history #875

merged 80 commits into from
Mar 2, 2023

Conversation

zeitschlag
Copy link
Contributor

@zeitschlag zeitschlag commented Jan 9, 2023

Rationale

Demo Description
RocketSim_Recording_iPhone_14_Pro_2023-02-23_09 52 04 Implement post-editing feature and edit history. Demo shows editing the status text and removing an image.

@zeitschlag zeitschlag self-assigned this Jan 9, 2023
@j-f1
Copy link
Contributor

j-f1 commented Feb 14, 2023

Since presumably only you and a couple of people ever installed an app using CoreData 8, would it be possible to make the changes to CoreData 8 directly instead of making a new version? (I think it’s also fine to change the optional status of a field without making a new version)

@kimar
Copy link
Contributor

kimar commented Feb 23, 2023

@j-f1 I was also considering this, I'll make the changes t model v8 directly then.

@kimar kimar marked this pull request as ready for review February 23, 2023 08:46
@kimar kimar added the enhancement New feature or request label Feb 23, 2023
@kimar kimar changed the title Post-Editing Implement post editing / edit history Feb 23, 2023
@kimar kimar requested a review from j-f1 February 23, 2023 09:25
@kimar kimar added this to the 1.4.12 milestone Feb 23, 2023
Copy link
Contributor

@j-f1 j-f1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome! I opened #951 with a few improvements; namely, attempting to emulate the styling of table view cells for StatusMetricRowView, improving display at large text sizes, and improving VoiceOver accessibility. It’s not currently possible to access the edit history via VoiceOver (underlying issue for that is IOS-70 which I will try to handle today or tomorrow).

Copy link
Contributor Author

@zeitschlag zeitschlag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the stuff looks good to me, although I'm a bit uncertain about Persistence+StatusEdit.swift.

@zeitschlag zeitschlag modified the milestones: 1.4.13, 1.4.14 Mar 1, 2023
@kimar kimar merged commit 0c224f4 into develop Mar 2, 2023
@kimar kimar deleted the 2-edit-post branch March 2, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants