Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PreviewCard for some sites is not displayed #16955

Closed
abcang opened this issue Nov 8, 2021 · 1 comment · Fixed by #16979
Closed

PreviewCard for some sites is not displayed #16955

abcang opened this issue Nov 8, 2021 · 1 comment · Fixed by #16979
Assignees
@Gargron
Labels
bug Something isn't working

Comments

@abcang
Copy link
Contributor

abcang commented Nov 8, 2021 •
edited

Expected behaviour

PreviewCard will be displayed.

Actual behaviour

PreviewCard is not displayed.

Steps to reproduce the problem

  1. Include https://official.fanbox.cc/ in your post.
  2. Check the ID of that post.
  3. Open the LinkCrawlWorker job of the corresponding ID from the morgue page of the sidekiq administration ( /sidekiq/morgue).
  4. You can see that the error no implicit conversion of String into Integer is displayed.

Specifications

This is a test post.
https://testingmstdn.abcang.net/@abcang/107241694706037663

Main branch after #16938
image

Mastodon v3.4.1:
image

I checked the structured data and found that it is an array. Therefore, access to the structured data is failing.
@abcang abcang added the bug Something isn't working label Nov 8, 2021
@ClearlyClaire
Copy link
Contributor

Assigned to avoid duplicate work as he is working on a PR that includes a fix for that issue

Gargron added a commit that referenced this issue Nov 13, 2021
@Gargron
Fix no link previews being generated for pages with invalid structure…
1256b91 
…d data

Fix #16955
@Gargron Gargron mentioned this issue Nov 13, 2021
Merged
Gargron added a commit that referenced this issue Nov 13, 2021
@Gargron
Fix no link previews being generated for pages with invalid structure…
5d7c852 
…d data (#16979)

Fix #16955
jesseplusplus pushed a commit to jesseplusplus/decodon that referenced this issue Feb 10, 2022
@Gargron @jesseplusplus
Fix no link previews being generated for pages with invalid structure…
9014689 
…d data (mastodon#16979)

Fix mastodon#16955
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Gargron Gargron

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix no link previews being generated for pages with invalid structured data mastodon/mastodon
3 participants
@Gargron @ClearlyClaire @abcang