Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow login through OpenID #7958

Closed
Zoddo opened this issue Jul 5, 2018 · 14 comments
Closed

Allow login through OpenID #7958

Zoddo opened this issue Jul 5, 2018 · 14 comments
Labels
suggestion Feature suggestion

Comments

@Zoddo
Copy link

Zoddo commented Jul 5, 2018

OpenID is a decentralized authentication system. It allows to delegate the authentication to a third party trusted by the end-user. The last version (OpenID Connect) works over OAuth 2.0. It's alrady used by a lot of websites, but usually limited to a few big providers like Google or Facebook (don't ask why...).

Allowing to login on Mastodon through OpenID would also prevent to have to remember another login/password.

For reference, @Sylvhem has submitted a request to add an OpenID provider in Mastodon: #4800.

@amalg
Copy link

amalg commented Jun 24, 2019

prevent to have to remember another login/password

Not just this, but it would also prevent the need for the mastodon instance to host and secure usernames and passwords. Managing accounts, forgotten passwords, "hacked" accounts, etc. is a pain. I'd much rather leave this to the IdP to deal with.

@stale
Copy link

stale bot commented Oct 26, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status/wontfix This will not be worked on label Oct 26, 2019
@Zoddo
Copy link
Author

Zoddo commented Oct 26, 2019

Bump to not have this issue closed by the stale bot. The suggestion is still valid ;)

@stale stale bot removed the status/wontfix This will not be worked on label Oct 26, 2019
@ChevronTango
Copy link

I too would like to give this feature a bump. OIDC is more useful than SAML for environmental like AWS.

@decentral1se
Copy link

decentral1se commented Jun 1, 2021

Hey folks #16221 has landed and I'm testing it as much as possible to help it get merged.

Any other folks who can lend a hand with docs / reviews / testing / etc.? That would be great.

@teutat3s
Copy link

teutat3s commented Nov 9, 2022

We're testing this and one doubt we still have if is there's a clever way to migrate / merge users who registered before enabling OIDC with keycloak from mastodon to the new SSO provider.

EDIT: Variables used for configuration:

# OpenID Connect
# --------------
OIDC_ENABLED=true
OIDC_DISPLAY_NAME="your SSO"
OIDC_ISSUER=https://auth.your.keycloak.domain/realms/your-realm
OIDC_DISCOVERY=true
OIDC_SCOPE="openid,profile,email"
OIDC_UID_FIELD=preferred_username
OIDC_REDIRECT_URI=https://your.mastodon.domain/auth/auth/openid_connect/callback
OIDC_SECURITY_ASSUME_EMAIL_IS_VERIFIED=true
OIDC_CLIENT_ID=redacted
OIDC_CLIENT_SECRET=redacted
# uncomment to only use OIDC for login / registration buttons
#OMNIAUTH_ONLY=true

@ThisIsMissEm
Copy link
Contributor

@decentral1se @teutat3s can this be extended to allow an input text area for IDP, rather than constraining to a single IDP?

This could then be used to interop with Solid & WebID's that contain a solid:oidcIssuer predicate: https://solidproject.org/TR/oidc-primer

Let me know if there's anything needed from the Solid side (I work at Inrupt, one of the companies helping build Solid)

@ThisIsMissEm
Copy link
Contributor

Also worth mentioning is the new OIDC Federation spec, there's some discussion here on that from the Solid side: solid/solid-oidc#207

@alansill
Copy link

Iʻve studied this and think itʻs time for a warning: DO NOT DO THIS if you think there may be the possibility that the account identifiers so created might ever want to be claimed for any other reason. Deleting an account created through OIDC UID or other SSO identifiers will render that UID permanently unavailable in the future. This is an undesirable feature in my opinion and I have filed issue #21071 to raise the topic for further investigation. I also endorse the comment above. #7958 (comment) as OIDC Federation both in principle and in practice can improve the federation experience for both users and server admins.

@lemniskett
Copy link

Is it possible not to create new account if the existing user doesn't exist yet?

@fame-odoo
Copy link

Is it possible not to create new account if the existing user doesn't exist yet?

I am actually wondering the same thing

@strk
Copy link

strk commented Oct 27, 2023

Had you considered using OpenID-2.0 too or would that belong to a different ticket ? I mention because OpenID-2.0 is already federated and providers are here already and different services already allow logging in via OpenID-2.0, for example:

@gotjoshua
Copy link

@decentral1se

#16221 has landed and I'm testing it as much as possible to help it get merged.

As #16221 is now merged, doesn't that close this issue?

@ThisIsMissEm
Copy link
Contributor

I'd say so, so this could be closed as completed @vmstan.

Adoption of something like OIDC Federation or similar could be a future thing.

@vmstan vmstan closed this as completed Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
suggestion Feature suggestion
Projects
None yet
Development

No branches or pull requests