add og:image:alt for media attachments in embeds #10779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ykzts
reviewed
May 18, 2019
Gargron
approved these changes
May 18, 2019
Gargron
pushed a commit
that referenced
this pull request
May 19, 2019
hiyuki2578
pushed a commit
to ProjectMyosotis/mastodon
that referenced
this pull request
Oct 2, 2019
hiyuki2578
pushed a commit
to ProjectMyosotis/mastodon
that referenced
this pull request
Oct 2, 2019
mashirozx
added a commit
to mashirozx/mastodon
that referenced
this pull request
Sep 20, 2020
* Use backend from glitch-soc for instance-only toots * Base frontend on privacy dropdown * Add backend support for local_only on status create Based off ThibG implementation on glitch #502 * Add local_only indicator in the status action bar * Add local_only indicator to detailed status * Normalize translations ran yarn build:development && i18n-tasks normalize && yarn manage:translations && i18n-tasks remove-unused * Add local_only to admin screens * Hide local statuses from user atom and from unlogged users * Add local only icon to status page * Fix issue with toggle in mobile * Add default federation option to settings * Fix wrong configuration fetched * Change setting wording * Check for empty "last_status" before sorting DM column (mastodon#9207) * Check for empty "last_status" before sorting * Small touchups for codeclimate * Update resolve_url_service.rb (mastodon#9188) * Increase default column width from 330px to 350px (mastodon#9227) * Optimize the process of following someone (mastodon#9220) * Eliminate extra accounts select query from FollowService * Optimistically update follow state in web UI and hide loading bar Fix mastodon#6205 * Asynchronize NotifyService in FollowService And fix failing test * Skip Webfinger resolve routine when called from FollowService if possible If an account is ActivityPub, then webfinger re-resolving is not necessary when called from FollowService. Improve options of ResolveAccountService * Fix follow limit validator reporting lower number past threshold (mastodon#9230) * Fix follow limit validator reporting lower number past threshold * Avoid floating point follow limit * Fix form validation flash message color and input borders (mastodon#9235) * Fix form validation flash message color and input borders * Fix typo * Display amount of freed disk space in tootctl media remove (mastodon#9229) * Display amount of freed disk space in tootctl media remove Fix mastodon#9213 * Fix code style issue * Add "Show thread" link to self-replies (mastodon#9228) Fix mastodon#4716 * Fix nil error regression from mastodon#9229 in tootctl media remove (mastodon#9239) Fix mastodon#9237 * Improve ActiveRecord connection in on_worker_boot (mastodon#9238) This is how it looks in the example in the Puma README * Check that twitter:player is valid before using it (mastodon#9254) Fixes mastodon#9251 * Fix emoji update date processing (mastodon#9255) * Perform deep comparison for card data when receiving new props (mastodon#9270) Fixes mastodon#9226 * Fix null error introduced in mastodon#9270 (mastodon#9275) * Fix race condition causing shallow status with only a "favourited" attribute (mastodon#9272) Fixes mastodon#9231 * Fix "tootctl media remove" can't count the file size (mastodon#9288) * Fixed an issue where "tootctl media remove" can not count the file size. * Fixed the problem pointed out by codeclimate. * Remove intermediary arrays when creating hash maps from results (mastodon#9291) * Prevent multiple handlers for Delete of Actor from running (mastodon#9292) * Fix filter ID not being a string in REST API (mastodon#9303) * Update Nginx config for Nanobox apps (mastodon#9310) The Nanobox files have gotten out of sync, a touch, with what Masto needs for Nginx settings. This PR updates them accordingly. * WebSub: ATOM before RSS (mastodon#9302) Hello, The ATOM feed contains the hub declaration for WebSub, but the RSS version does not. RSS/ATOM readers will typically pick whichever version comes first, and will thus not see the WebSub feature. I therefore suggest putting the ATOM version first, as it is more feature-rich than its RSS counterpart is. Clients not compatible with ATOM would not pick it anyway due to the different type attribute. A more complicated alternative would be to declare the WebSub feature in the RSS version as well, using something like the following code, and ensuring that clients subscribed to the RSS version would receive PuSH updates just like those subscribed to the ATOM version. ````xml <rss version="2.0" xmlns:webfeeds="http://webfeeds.org/rss/1.0" xmlns:atom="http://www.w3.org/2005/Atom"> <channel> <atom:link rel="self" type="application/rss+xml" href="https://diaspodon.fr/users/test.rss"/> <atom:link rel="hub" href="https://diaspodon.fr/api/push"/> </channel> </rss> ``` * Touch account on successful response, change char shown when culled (mastodon#9293) Just the color is not enough change since not everyone uses colored terminals. Touching the account makes it so that the account is not in the threshold window in case of running again * Ignore JSON-LD profile in mime type comparison (mastodon#9179) Ignore JSON-LD profile in mime type comparison * Fix connect timeout not being enforced (mastodon#9329) * Fix connect timeout not being enforced The loop was catching the timeout exception that should stop execution, so the next IP would no longer be within a timed block, which led to requests taking much longer than 10 seconds. * Use timeout on each IP attempt, but limit to 2 attempts * Fix code style issue * Do not break Request#perform if no block given * Update method stub in spec for Request * Move timeout inside the begin/rescue block * Use Resolv::DNS with timeout of 1 to get IP addresses * Update Request spec to stub Resolv::DNS instead of Addrinfo * Fix Resolve::DNS stubs in Request spec * Bump version to 2.6.2 * add loglevel to ffmpeg in gif upload (mastodon#9368) * Allow hyphens in the middle of remote user names (mastodon#9345) Fixes mastodon#9309 This only allows hyphens in the middle of a username, much like dots, although I don't have a compelling reason to do so other than keeping the changes minimal. * Fix nil error when no DNS addresses are found for host (mastodon#9379) * Don't count suspended users in user count (mastodon#9380) Fix mastodon#7637 * Skip deliveries to inboxes that have already been marked as unavailable (mastodon#9358) * Fix TLS handshake timeout not being enforced (mastodon#9381) Follow-up to mastodon#9329 * Bump version to 2.6.3 * Remove npm-run-all dependency (mastodon#9401) Fix mastodon#9359 * Bump version to 2.6.4 * Preload common JSON-LD contexts (mastodon#9412) Fixes mastodon#9411 * Include replies to list owner and replies to list members in list statuses (mastodon#9324) * Bump version to 2.6.5 * Only stream local-only toots to logged-in users * Normalize translations * Bumps copyright year in README.md to 2019 (mastodon#9939) This is so incredibly small, but assuming this is a needed change. Might want to check year in other files. * Fix link color in high-contrast theme, add underlines (mastodon#9949) Improve sorting of default themes in the dropdown * Replace unlock-alt icon with unlock (mastodon#9952) * Allow most kinds of characters in URL query (fixes mastodon#8408) (mastodon#8447) * Allow unicode characters in URL query strings Fixes mastodon#8408 * Alternative approach to unicode support in urls Adds PoC/idea to approch this problem. * Fix authorized applications list page design (mastodon#9969) * Fix not showing custom emojis in share page emoji picker (mastodon#9970) * [UI] Fix whitespace being applied to div instead of p (mastodon#9968) * fix large line breaks * fix ascii art posts * Hide misleading “You will be sent a confirmation e-mail” hint from admin view (mastodon#9973) Thanks @wryk for noticing this issue. * Fix Tombstone.delete_all ArgumentError (mastodon#9978) * Only URLs extract with pre-escaped text (mastodon#9991) * [test] add japanese hashtag testcase * Only URLs extract with pre-escaped text ( mastodon#9989 ) * Fix URL linkifier grabbing full-width spaces and quotations (mastodon#9997) Fix mastodon#9993 Fix mastodon#5654 * Fix IntersectionObserverArticle not hiding some out-of-view items (mastodon#9982) IntersectionObserverArticle is made to save on RAM by avoiding fully rendering items that are far out of view. However, it did not work for items spawned outside the intersection observer. * Fix timeline jumps (mastodon#10001) * Avoid two-step rendering of statuses as much as possible Cache width shared by Video player, MediaGallery and Cards at the ScrollableList level, pass it down through StatusList and Notifications. * Adjust scroll when new preview cards appear * Adjust scroll when statuses above the current scroll position are deleted * Don't focus spiler input when disabled spoiler (mastodon#10017) * Move sending account Delete to anyone but the account's followers to the pull̀ queue (mastodon#10016) * Add support for IPv6 only MXes in Email validation (mastodon#10009) * Add support for IPv6 only MXes * Fixed email validator tests * Save IP address used for sign-up, not only sign-in (mastodon#10026) Fixes mastodon#9995 * Fix color of static page links in high contrast theme (mastodon#10028) * Fix hashtags select styling in default and high contrast themes (mastodon#10029) * Fix style regressions on landing page (mastodon#10030) * Add tight rate-limit for API deletions (mastodon#10042) Deletions take a lot of resources to execute and cause a lot of federation traffic, so it makes sense to decrease the number someone can queue up through the API. 30 per 30 minutes * Fix hashtag column not subscribing to stream on mount (mastodon#10040) Fix mastodon#9895 * Create Redisable#redis (mastodon#9633) * Create Redisable * Use #redis instead of Redis.current * Alternative handling of private self-boosts (mastodon#9998) * When self-boosting, embed original toot into Announce serialization * Process unknown self-boosts from Announce object if it is more than an URI * Add some self-boost specs * Only serialize private toots in self-Announces * Filter incoming Create activities by relation to local activity (mastodon#10005) Reject those from accounts with no local followers, from relays that are not enabled, which do not address local accounts and are not replies to accounts that do have local followers * Filter incoming Announce activities by relation to local activity (mastodon#10041) * Filter incoming Announce activities by relation to local activity Reject if announcer is not followed by local accounts, and is not from an enabled relay, and the object is not a local status Follow-up to mastodon#10005 * Fix tests * Add logging for rejected ActivityPub payloads and add tests (mastodon#10062) * Fix Announce activities of unknown statuses not fetching those statuses (mastodon#10065) Regression from mastodon#9998 * Fix relay enabling/disabling not resetting inbox availability status (mastodon#10048) Fix mastodon#10033 * Change robots.txt to exclude some URLs (mastodon#10037) - Exclude static assets - Exclude uploaded files - Exclude alternate versions of the profile page - Exclude media proxy URLs * Change robots.txt to exclude only media proxy URLs (mastodon#10038) * Revert "Change robots.txt to exclude some URLs (mastodon#10037)" This reverts commit 80161f4. * Let's block media_proxy /media_proxy/ is a dynamic route used for requesting uncached media, so it's probably bad to let crawlers use it * misleading comment * Improve image description user experience (mastodon#10036) * Add image descriptions to searchable post content. * Allow multi-line image descriptions. * Request image descriptions in the same query as posts when creating the search index. (see mastodon#10036 (comment)) * perf: run node directly when streaming (mastodon#10032) * Fix breaks when opening a reply tree in WebUI (mastodon#10046) fix mastodon#10045 * Change conversations to always show names of other participants (mastodon#10047) Fix mastodon#9190 * Change buttons on timeline preview to open the interaction dialog (mastodon#10054) Fix mastodon#9922 * Change error graphic to hover-to-play (mastodon#10055) Fix mastodon#6060 * Add registrations attribute to instance entity in REST API (mastodon#10060) Fix mastodon#9350 * Add vapid_key to the application entity in the REST API (mastodon#10058) Fix mastodon#8785 * Fix mutes, blocks, domain blocks and follow requests not paginating (mastodon#10057) Regression from mastodon#9581 * Fix crash on public hashtag pages when streaming fails (mastodon#10061) * Bump version to 2.7.2 * Do not leak local-only toots to remote mentioned users * Add description on hover in media gallery (mastodon#10713) * Fix some colors of high contrast theme (mastodon#10711) * Fix "nothing here" text color of high contrast * Fix counter border color of high contrast * Bring back crossed eye icon on gallery (mastodon#10715) * Improve poll link accessibility (mastodon#10720) * Add distinction between hover and active/focus states * Resolves mastodon#10198 * Change icon and label depending on whether media is marked as sensitive (mastodon#10748) * Change icon and label depending on whether media is marked as sensitive * WiP use a checkbox * Fix some colors in light theme (mastodon#10754) * Fix typo in light theme * Fix background color of empty column * Adds click-able div that expands status (mastodon#10733) (mastodon#10766) The clickable div is positioned under the account avatar and covers all empty space below it to the end of the status. * Minor performance improvements and cleanup in formatter (mastodon#10765) * Prevent from publicly boosting one's own private toots (mastodon#10775) * add og:image:alt for media attachments in embeds (mastodon#10779) * Add post-deployment migration script to delete public-boosts-of-private-toots (mastodon#10783) * fix `isSubmitting` prop case (mastodon#10785) * Fix “invited by” not showing up for invited accounts in admin interface (mastodon#10791) * Bump version to 2.8.3 * Retry ActivityPub inbox delivery on HTTP 401 and 408 errors (mastodon#10812) HTTP 401 responses returned by Mastodon's inbox controller may be temporary if, for instance, the requesting user's actor/key json could not be retrieved in a timely fashion. This changes allow retries instead of dropping the message entirely. Also added HTTP 408 as that error is by nature temporary. * Move signature verification stoplight to the requests themselves (mastodon#10813) * Move signature verification stoplight to the requests themselves This avoids blocking messages from known keys for 5 minutes when only one fails… * Put the stoplight on the actual client IP, not a potential reverse proxy * Fix possible race condition when processing statuses (mastodon#10815) * Improve streaming server security (mastodon#10818) * Check OAuth token scopes in the streaming API * Use Sec-WebSocket-Protocol instead of query string to pass WebSocket token Inspired by kubevirt/kubevirt#1242 * Bump version to 2.8.4 * Fix merge issues * Fix account URI in UpdatePollSerializer (mastodon#11194) * Fix account URI in UpdatePollSerializer Fixes mastodon#11185 * Add specs * Fix swiping columns on mobile sometimes failing (mastodon#11200) Fixes mastodon#9779 * Fix option to send e-mail notification about account action always being true (mastodon#11242) * Fix BackupService crashing when an attachment is missing (mastodon#11241) * Fix BackupService crashing when an attachment is missing For various reasons such as admin error or out-of-sync media and database backups, it might be possible for local attachments to be lost. This commit allows the BackupService to continue its work even if some media file is missing. * Change error message * Fix Status.remote scope matching *all* statuses (mastodon#11265) * Fix BlockService trying to reject incorrect follow request (mastodon#11288) Fixes mastodon#11148 * Fix invites not being disabled upon account suspension (mastodon#11412) * Disable invite links from disabled/suspended users * Add has_many invites relationship to users * Destroy unused invites when suspending an account * Update fuubar dependency to 2.4.1 (mastodon#11248) See also: thekompanee/fuubar#111 * Fix support for MP4 files that are actually M4V files (mastodon#11210) Resolve mastodon#11187 * Fix expiration date of filters being set to “Never” when editing them (mastodon#11204) When editing a custom filter, select the shortest preset duration that still covers the remaining time of that filter. Fixes mastodon#9506 * Fix statsd UDP sockets not being cleaned up in Sidekiq (mastodon#11230) * Remove unused StatsD code and expose StatsD as a global variable (mastodon#11232) The instrumentation code was used for StatsD metrics collection prior to the switch to the nsa gem and should have been removed at that point as it no longer does anything at all * Fix some flash notices/alerts staying on unrelated pages (mastodon#11364) * Fix `alerts` booleans not being typecast correctly in push subscription (mastodon#11343) * Fix `alerts` booleans not being typecast correctly in push subscription Fix mastodon#10789 * Fix typo * Optimize makeGetStatus (mastodon#11211) * Optimize makeGetStatus Because `ImmutableList.filter` always returns a new object and `createSelector` memoizes based on object identity, the selector returned by `makeGetStatus` would *always* execute. To avoid that, we wrap `getFilters` into a new memoizer that memoizes based on deep equality, thus returning the same object as long as the filters haven't changed, allowing the memoization of `makeGetStatus` to work. Furthermore, we memoize the compiled regexs instead of recomputing them each time the selector is called. * Fix memoized result being cleared too often * Make notifications use memoized getFiltersRegex * Memoize ancestorIds and descendantIds in detailed status view (mastodon#11234) * Fix boosting & unboosting preventing a boost from appearing in the TL (mastodon#11405) * Fix boosting & unboosting preventing a boost from appearing in the TL * Add tests * Avoids side effects when aggregate_reblogs isn't true * Fix delete regression (mastodon#11450) Regression from ff789a7 * Apply filters to poll options (mastodon#11174) * Apply filters to poll options in WebUI Fixes mastodon#11128 * Apply filters to poll options server-side * Add poll options to searchable text * Fix unnecessary SQL query performed on unauthenticated requests (mastodon#11179) * Add message telling FTS is disabled when no toot can be found because of this (mastodon#11112) * Add message telling FTS is disabled when no toot can be found because of this Fixes mastodon#11082 * Remove info icon and reword message * Display FTS warning based on actual search term, not the one being typed (mastodon#11202) Follow-up to mastodon#11112 * Scroll to compose form rather than reply indicator on focus (mastodon#11182) * When sending a toot, ensure a CW is only set if the CW field is visible (mastodon#11206) In some occasions, such as the browser or a browser extension auto-filling the existing but disabled/hidden CW field, a CW can be set without the user knowing. * When deleting & redrafting a poll, fill in closest expires_in (mastodon#11203) Use the smallest preset expires_in such that the new poll would not expire before the old one. In the typical case of a quick delete & redraft, this results in using the same poll duration. Fixes mastodon#10567 * Only scroll to the compose form if it's not horizontally in the viewport (mastodon#11246) Avoids jumping the scroll around vertically when giving it focus and editing long toots. * Display custom emoji in bio field names (mastodon#11350) Already displayed in public pages, but not WebUI * Play animated custom emoji on hover (mastodon#11348) * Play animated custom emoji on hover in status * Play animated custom emoji on hover in display names * Play animated custom emoji on hover in bios/bio fields * Add support for animation on hover on public pages emojis too * Fix tests * Code style cleanup * Fix animate on hover in poll options without CW (mastodon#11404) * Change domain block behaviour to prevent creation of accounts from suspended domains (mastodon#11219) * Change ActivityPub::DeliveryWorker to not retry HTTP 501 errors (mastodon#11233) * Change the retry limit in error of web push notification (mastodon#11292) - Change the maximum count of retry for web push notification (Default -> 5). - In case of high load of subscribe server, the retries will be repeated many times. - Because the retries occupy the default queue, maximum retry count should be reduced. * Change default interface of web and streaming from 0.0.0.0 to 127.0.0.1 (mastodon#11302) * Make puma bind address configurable with BIND env var (mastodon#11326) * Change terms and privacy policy pages to always be accessible (mastodon#11334) Fix mastodon#11328 * Change language detection to include hashtags as words (mastodon#11341) * Fix only one middle dot being recognized in hashtags (mastodon#11345) Fix mastodon#10934 * Change Dockerfile to bind to 0.0.0.0 instead of docker-compose.yml (mastodon#11351) * Fix sanitizing lists contents (mastodon#11354) * Add test * Fix code for sanitizing nested lists stripping all tags * Fix avatar animation on hover when not logged in (mastodon#11349) * Added logout to dropdown menu (mastodon#11353) * Added logout to dropdown menu * Triggering build-and-test with empty commit as it seems it failed due to some internal failure * Looks fine, ready to review * Added changes from review * method can be null without any problems * Also target can be null * Disallow numeric-only hashtags (mastodon#11363) * Add spec covering numeric-only hashtags * Fix hashtag regex * Change locale detection to run once per session (mastodon#8657) Fix mastodon#6462 * Bind servers to 0.0.0.0 in Procfile (mastodon#11378) * Bind to 0.0.0.0 * Make Procfile common to main and streaming apps * Change account domain block to clear out notifications and follows (mastodon#11393) * Remove pre from version, add extra suffix variable (mastodon#11407) * Remove timestamps from converted images to make them deterministic (mastodon#11408) * Prevent archiving when user set "noindex" (mastodon#11421) * Disable list title validation button when list title is empty (mastodon#11475) * Fix timestamp on featured tag (mastodon#11477) It resolves mastodon#11338 * Trap tab in modals (mastodon#11493) * Fix privacy dropdown active state when dropdown is placed on top of it (mastodon#11495) * Improve dropdown menu keyboard navigation (mastodon#11491) * Allow selecting menu items with the space bar in status dropdown menus * Fix modals opened by keyboard navigation being immediately closed * Fix menu items triggering modal actions * Add Tab trapping inside dropdown menu * Give focus back to last focused element when status dropdown menu closes * Improve keyboard navigation in privacy dropdown (mastodon#11492) * Trap tab in privacy dropdown * Give focus back to last focused element when privacy dropdown menu closes * Actually give back focus to the element that had it before clicking the dropdown * Fix image uploads being perfectly white when canvas read access is blocked (mastodon#11499) Fixes mastodon#11496 * Improve focus handling with dropdown menus (mastodon#11511) - Focus first item when activated via keyboard - When the dropdown menu closes, give back the focus to the actual element which was focused prior to opening the menu * Fix "cancel follow request" button having unreadable text in web UI (mastodon#11521) Fix mastodon#11478 * Add GIF and WebP support for custom emojis (mastodon#11519) Fix mastodon#11466 * Fix pinned statuses API returning pagination headers (mastodon#11526) Fix mastodon#10227 * Fix crash when saving invalid domain name (mastodon#11528) Fix mastodon#7629 * Fix “read more” button behing hidden (regression from mastodon#11404) (mastodon#11522) * Fix “read more” button behing hidden (regression from mastodon#11404) This has the side-effect of putting the “Read more” button below possibly trunctated polls instead of putting the poll below the “Read more” * Remove dead code * Bump version to 2.9.3 Co-authored-by: Renato "Lond" Cerqueira <renato@lond.com.br> Co-authored-by: Steven Tappert <admin@dark-it.net> Co-authored-by: m.b <mbajur@users.noreply.github.com> Co-authored-by: Eugen Rochko <eugen@zeonfederated.com> Co-authored-by: ThibG <thib@sitedethib.com> Co-authored-by: mayaeh <mayaeh@marimo-net.org> Co-authored-by: Dan Hunsaker <danhunsaker@gmail.com> Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr> Co-authored-by: valerauko <vale@valerauko.net> Co-authored-by: Hugo Gameiro <hmgameiro@gmail.com> Co-authored-by: Sam Schlinkert <sschlinkert@gmail.com> Co-authored-by: Clar Charr <clar@charr.xyz> Co-authored-by: Jakub Mendyk <jakubmendyk.szkola@gmail.com> Co-authored-by: rinsuki <428rinsuki+git@gmail.com> Co-authored-by: trwnh <a@trwnh.com> Co-authored-by: abcang <abcang1015@gmail.com> Co-authored-by: Hinaloe <hina@hinaloe.net> Co-authored-by: Franck Zoccolo <franck@zoccolo.com> Co-authored-by: ysksn <bluewhale1982@gmail.com> Co-authored-by: nightpool <nightpool@users.noreply.github.com> Co-authored-by: Ben Lubar <ben.lubar+github@gmail.com> Co-authored-by: Nolan Lawson <nolan@nolanlawson.com> Co-authored-by: nzws <git-yuzu@svk.jp> Co-authored-by: Jeong Arm <kjwonmail@gmail.com> Co-authored-by: Maciek Baron <thebezet@gmail.com> Co-authored-by: nzws <git@nzws.me> Co-authored-by: Neil Moore <dar13.dev@gmail.com> Co-authored-by: Ben Lubar <ben.lubar@gmail.com> Co-authored-by: Georg Gadinger <nilsding@nilsding.org> Co-authored-by: han@highemelry <high.emerly.ytfin@gmail.com> Co-authored-by: Daigo 3 Dango <zunda@users.noreply.github.com> Co-authored-by: koyu <me@koyu.space> Co-authored-by: Clar Fon <them@lightdark.xyz>
messenjahofchrist
pushed a commit
to Origin-Creative/mastodon
that referenced
this pull request
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.