Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add indication to admin UI of whether a report has been forwarded #13237

Merged
merged 2 commits into from Dec 15, 2020

Conversation

ClearlyClaire
Copy link
Contributor

@ClearlyClaire ClearlyClaire commented Mar 9, 2020

Reports list

In the lists of reports, an arrow (fontawesome's “share”) is displayed when the report is known to have been forwarded.

image

Report

For reports about remote users, the table will show either of those according to the situation:

  • Forwarded: Yes
  • Forwarded: No
  • Forwarded: Unknown (reported before the information was recorded)

image

@ClearlyClaire ClearlyClaire force-pushed the features/report-show-forwarded branch from a15d470 to a17e2d3 Compare March 9, 2020 17:31
@SuperSandro2000
Copy link
Contributor

What means forwarded?

@ClearlyClaire
Copy link
Contributor Author

@SuperSandro2000 when a user reports an account that's on a remote server, they have the option to forward that report to the originating server as well. That's what it means.

@Gargron
Copy link
Member

Gargron commented Mar 12, 2020

Maybe instead of "Yes", "Yes, %{domain} has been notified"? Other mods/admins absolutely will not know what "Forwarded" means, though I understand that has to be short to fit in the table column.

@ClearlyClaire
Copy link
Contributor Author

Hm, I can do that, but I'm not sure what we should do for “No” then :/

@Gargron
Copy link
Member

Gargron commented Mar 12, 2020

I'm not really sure what the utility of this information is. Like I guess "Maybe there is hope origin will take care of this before I have to"? But is that really so useful to know on the report overview page? Also, the forward icon looks a lot like the reply icon. People will not know what it means for sure.

@ClearlyClaire
Copy link
Contributor Author

I'm not really sure what the utility of this information is. Like I guess "Maybe there is hope origin will take care of this before I have to"?

I mean, I have seen this request a bunch of time. I guess to have an idea if the remote admins not doing anything is because they didn't want to, or because they weren't been made aware of it, for instance.

@nightpool was interested

But is that really so useful to know on the report overview page? Also, the forward icon looks a lot like the reply icon. People will not know what it means for sure.

Well, it doesn't take up much space. Maybe another icon would be better suited but idk which. Thankfully there's a tooltip.

@stale
Copy link

stale bot commented Jul 10, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status/wontfix This will not be worked on label Jul 10, 2020
@stale stale bot closed this Jul 17, 2020
@ClearlyClaire ClearlyClaire reopened this Oct 16, 2020
@stale stale bot removed the status/wontfix This will not be worked on label Oct 16, 2020
@Siphonay
Copy link

A situation arose on a server I’m moderating yesterday where we didn't feel like it was appropriate to take action ourselves and would rather know how the targeted instance's admins would deal with it. Knowing if a report was forwarded would had saved us asking about it to the admins or the users who made the report. I think such a function would be useful

@progval
Copy link
Contributor

progval commented Oct 16, 2020

Same as @Siphonay, so I know if I have to contact the remote admins.

Additionally, it would be nice to have an option for admins to forward the report even if the user initially didn't

@Psycojoker
Copy link

Hello,

As an admin/moderator having this information would help greatly to:

  • know the intent of the member of our community: do they expect us to act locally or do they also expect this from the other instance
  • know if the other instance if aware of that and so, if it's a serious case be inform on how they act on it
  • this last information is important to check if this other instance has a moderation strategy similar to ours and if not, if we need to take further actions (like contacting them and/or escalate to more coercive actions)

As moderator of our communities, ensuring that our members are evolving as much as possible in a space that matches our CoC is very important, this kind of information will help us do a better job.

@StarryAster
Copy link

I think that could also be useful in situations where a forwarded report is unclear or in a different language, in a way that makes contacting the forwarded instance's admins about the report more urgent than if the report was just solved locally first.

This is pretty minor in comparison to other stated reasons, though.

@renatolond
Copy link
Contributor

Passing by to say that I already do this manually (reaching out to users when the report is from another instance to see if they forwarded it or if, depending on the case, I should myself do a second report to forward to the original instance).
So this would help quite a lot :)

@ClearlyClaire
Copy link
Contributor Author

@Gargron can we have that? There's clearly interest from multiple instance admins for that feature.

config/locales/en.yml Outdated Show resolved Hide resolved
@ClearlyClaire
Copy link
Contributor Author

Updated according to reviews:
image

@@ -46,6 +46,16 @@
%td{ colspan: 2 }
- if @report.action_taken?
= table_link_to 'envelope-open', t('admin.reports.reopen'), admin_report_path(@report, outcome: 'reopen'), method: :put
- unless @report.target_account.local?
%tr
%th= t('admin.reports.forwarded')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this string is missing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed 😩
Fixed.

@Gargron Gargron merged commit 1390cc1 into mastodon:master Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants