Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix e-mail confirmations API not working correctly #16348

Merged
merged 2 commits into from Jun 2, 2021
Merged

Fix e-mail confirmations API not working correctly #16348

merged 2 commits into from Jun 2, 2021

Conversation

Gargron
Copy link
Member

@Gargron Gargron commented Jun 1, 2021

No description provided.

ClearlyClaire
ClearlyClaire requested changes Jun 2, 2021
View reviewed changes
Gemfile.lock Outdated Show resolved Hide resolved
@ClearlyClaire
Copy link
Contributor

What cases does it solve?

@Gargron
Copy link
Member Author

Gargron commented Jun 2, 2021

What cases does it solve?

The API allows a user to correct e-mail typos after sign-up through an app and/or re-request a confirmation link if hasn't arrived.

@ClearlyClaire
Copy link
Contributor

I know, I meant, why was that API broken that this PR solves?

@Gargron
Copy link
Member Author

Gargron commented Jun 2, 2021

I know, I meant, why was that API broken that this PR solves?

Oh. unconfirmed_email is not filled for new accounts. Devise only fills it out when a user is confirmed and changes their e-mail. But by that point confirmed? is already true. So the condition was never true.

@ClearlyClaire
Copy link
Contributor

Ok, in this case, shouldn't, for a confirmed account, unconfirmed_email be updated instead of email?

@Gargron
Copy link
Member Author

Gargron commented Jun 2, 2021

Ok, in this case, shouldn't, for a confirmed account, unconfirmed_email be updated instead of email?

Devise handles it

@Gargron Gargron merged commit 1410dff into main Jun 2, 2021
@Gargron Gargron deleted the fix-email-reconfirm-api branch June 2, 2021 19:08
GensouSakuya pushed a commit to GensouSakuya/mastodon that referenced this pull request Jun 3, 2021
@Gargron @GensouSakuya
Fix e-mail confirmations API not working correctly (mastodon#16348)
12360c3 
* Fix e-mail confirmations API not working correctly

* Fix typo
chrisguida pushed a commit to Start9Labs/mastodon that referenced this pull request Feb 26, 2022
@Gargron @chrisguida
Fix e-mail confirmations API not working correctly (mastodon#16348)
81bce91 
* Fix e-mail confirmations API not working correctly

* Fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClearlyClaire ClearlyClaire ClearlyClaire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Gargron @ClearlyClaire