Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possible duplicate statuses in timelines in some edge cases #17971

Merged
merged 1 commit into from Apr 6, 2022

Conversation

ClearlyClaire
Copy link
Contributor

In some rare cases, when receiving statuses out of order from the streaming API then polling from the REST API, it was possible for the expandNormalizedTimeline function to insert duplicates in the timeline, which would then result in several bugs.

This commits ensures that there are no duplicates inserted in the timeline.

@ClearlyClaire ClearlyClaire marked this pull request as ready for review April 6, 2022 13:01
In some rare cases, when receiving statuses out of order from the streaming
API then polling from the REST API, it was possible for the
`expandNormalizedTimeline` function to insert duplicates in the timeline,
which would then result in several bugs.

This commits ensures that there are no duplicates inserted in the
timeline.
@Gargron Gargron merged commit dd4c156 into mastodon:main Apr 6, 2022
kadoshita pushed a commit to kadoshita/mastodon that referenced this pull request Apr 9, 2022
…odon#17971)

In some rare cases, when receiving statuses out of order from the streaming
API then polling from the REST API, it was possible for the
`expandNormalizedTimeline` function to insert duplicates in the timeline,
which would then result in several bugs.

This commits ensures that there are no duplicates inserted in the
timeline.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants