Improve follow recommendations SQL query #25334
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A server admin reported that this query took 29 hours to run on their instance, using PostgreSQL 14 with up-to-date vacuum & statistics.
After some investigation, we found out that the plan was very wrong and resulted in 300B+ rows being generated in a temporary table.
Switching from a
JOIN
toNOT EXISTS
fixes the issue and the query is now behaving as expected.This has been tested on PostgreSQL 12 on a large server, and performs the same as with the
JOIN
on this server.Fixes #25191