Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix N+1 on AtomSerializer #7669

Merged
merged 1 commit into from May 29, 2018

Conversation

abcang
Copy link
Contributor

@abcang abcang commented May 29, 2018

Although status.mentions is preloaded, the query was executed again because order was called. So change order to sort_by to prevent N + 1.

@ykzts ykzts added performance Runtime performance ostatus labels May 29, 2018
@Gargron Gargron merged commit 90908fc into mastodon:master May 29, 2018
@abcang abcang deleted the fix/nplus1_on_atom_serializer branch May 29, 2018 15:52
abcang added a commit to pixiv/mastodon that referenced this pull request Jun 4, 2018
lawremipsum pushed a commit to lawremipsum/mspsocial-mastodon that referenced this pull request Jul 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Runtime performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants