Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce usage of LD signatures #9659

Merged
merged 5 commits into from Dec 30, 2018
Merged

Conversation

@ClearlyClaire
Copy link
Collaborator

@ClearlyClaire ClearlyClaire commented Dec 30, 2018

LDS is used for forwarding replies and deletes, as well as for relays.
There is no need to LDS-sign “private” activities like Follow, Block etc., nor signing private toots.

Adding tests may be useful…

@ClearlyClaire ClearlyClaire force-pushed the ClearlyClaire:fixes/ld-sign branch Dec 30, 2018
@ClearlyClaire ClearlyClaire force-pushed the ClearlyClaire:fixes/ld-sign branch 2 times, most recently Dec 30, 2018
@ClearlyClaire ClearlyClaire changed the title [WiP] Reduce usage of LD signatures Reduce usage of LD signatures Dec 30, 2018
@ClearlyClaire ClearlyClaire force-pushed the ClearlyClaire:fixes/ld-sign branch to 2ce99f7 Dec 30, 2018
@Gargron Gargron merged commit 2909326 into mastodon:master Dec 30, 2018
11 checks passed
11 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details
@ClearlyClaire ClearlyClaire deleted the ClearlyClaire:fixes/ld-sign branch Mar 14, 2019
hiyuki2578 added a commit to ProjectMyosotis/mastodon that referenced this pull request Oct 2, 2019
* Do not LDS-sign Follow, Accept, Reject, Undo, Block

* Do not use LDS for Create activities of private toots

* Minor cleanup

* Ignore unsigned activities instead of misattributing them

* Use status.distributable? instead of querying visibility directly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants