charset.convertUTF8ToBytes not working right for some characters #5

devongovett opened this Issue Apr 26, 2010 · 0 comments


None yet
1 participant

I have found that the convertUTF8ToBytes function in the charset module is not converting some data correctly. The first instance of this arises when trying to save binary data (such as images). The convertUTF8ToBytes function seems to be converting this binary data beyond recognition.

The second issue occurs when trying to save special characters such as smart quotes and other unicode characters.

The issue seems to be solved by not converting to bytes at all. I changed the function to the following:

var convertUTF8ToBytes = function(str) {
    if(typeof(str)=='undefined') return undefined;
    if(typeof(str)=='undefined') return undefined;

    return str;

This seems to be working for me, but I haven't tested all possible scenarios.

Thanks for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment