Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: extract to make_compare_links_from_lockfiles #39

Merged
merged 2 commits into from Mar 3, 2019

Conversation

Projects
None yet
2 participants
@sue445
Copy link

sue445 commented Mar 2, 2019

Context

I want to use compare_linker from outside GitHub (e.g. GitLab)

So I want to use following from my code.
https://github.com/masutaka/compare_linker/blob/v1.4.2/lib/compare_linker.rb#L29-L60

Example

gitlab = Gitlab.client
old_lockfile = gitlab.file_contents("my/project", "Gemfile.lock", "OLD_SHA1")
new_lockfile = gitlab.file_contents("my/project", "Gemfile.lock", "NEW_SHA1")

compare_linker = CompareLinker.new("dummy", "dummy")
compare_linker.make_compare_links_from_lockfiles(Bundler::LockfileParser.new(old_lockfile), Bundler::LockfileParser.new(new_lockfile))
@masutaka
Copy link
Owner

masutaka left a comment

Thanks!

@masutaka masutaka merged commit 4a54cb7 into masutaka:master Mar 3, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@masutaka

This comment has been minimized.

Copy link
Owner

masutaka commented Mar 3, 2019

Just released v1.4.3 🎉

Thanks once again @sue445!

@sue445 sue445 deleted the sue445:make_compare_links_from_lockfiles branch Mar 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.