Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Subset.recalculate was stopping after the first change was applied. #7

Merged
merged 1 commit into from

2 participants

@garbelini

If changed == false _updateModelMembership was not being called at all and the remaining elements were unaffected. Changing the order fixed the problem for me.

@masylum masylum merged commit 5869087 into from
@masylum
Owner

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  backbone.subset.js
View
2  backbone.subset.js
@@ -115,7 +115,7 @@
// re-evaluate each model's eligibility
changed = _.result(this, 'parent').reduce(function (changed, model) {
- return changed || self._updateModelMembership(model, {silent: true});
+ return self._updateModelMembership(model, {silent: true}) || changed;
}, false);
// only trigger reset event if the subset actually changed
Something went wrong with that request. Please try again.