New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort out a problem that arose with nesting/restoring #102

Merged
merged 1 commit into from Sep 15, 2017

Conversation

1 participant
@matatk
Owner

matatk commented Sep 15, 2017

  • Added a test for when the nesting skips back two levels...
  • ...then realised that the error was not in the landmark-finding code, but the popup UI.
  • Fixed the pop-up UI to cope with this.
  • Should probably factor out the bit that constructs the DOM, and test it!
Sort out a problem that arose with nesting/restoring
* Added a test for when the nesting skips back two levels...
* ...then realised that the error was not in the landmark-finding code, but the popup UI.
* Fixed the pop-up UI to cope with this.
* Should probably factor out the bit that constructs the DOM, and test it!

@matatk matatk merged commit 8c7df44 into master Sep 15, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@matatk matatk deleted the nested-level-restoration branch Sep 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment