New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for dynamic content changes #111

merged 16 commits into from Nov 3, 2017


1 participant

matatk commented Nov 3, 2017

This supports situations where the page changes dynamically and the landmarks change because of this, thus this closes #84 (as well as other issues, as noted in the commit messages).

matatk added some commits Sep 4, 2017

Explore dynamic landmarks
This is a manual test for now.
Test page; Code tweak
* Compare element to undefined directly.
* Improve the injected landmarks test page by adding nesting.
Make a test version; Lint with addons-linter
* This is for Firefox users, to test the MutationObserver stuff.
* Use Mozilla addons-linter to check extensions before they are uploaded
  (currently Firefox only).
* Remove console output when disabling extension on certain URLs.
* Remove the "loading" ("...") indicator from the badge (it should be
  robust enough not to need this, and it should not expose such internal
  details to the end-user).
* Only say how long it took to find landmarks when they are (re-)found
  as a result of a MutationObserver.
* Make LandmarksFinder.filter() cleaner using map().
Groundwork for skip-to-main
* Roll back to deepmerge 1.5.x due to change in behaviour
* Add command definition for main-landmark.
* Add translation text for main-landmark.
* Simplify command handling in background script.
* Make error throwing consistent.
Version bumping
All seems well except addons-linter is complaining about PNGs, though
they have always shown up fine...
Skip to main; Removing redundant code
* Remove unused this.currentLandmarkElement() from LandmarksFinder.
* Track which element is the <main>/role="main" element.
* Add this.selectMainElement() to LandmarksFinder.
* Handle the 'main-landmark' message in
* Add info on skipping to the main landmark to the README.

This completes the work started in
f1331fa and closes #106.
Tidying comments; Mutation observer stuff
* Tidy up mutation observer setup stuff.
* Remove a logic error (spurious `return false`) from mutation observer
  mutation handler code.
* Make comments and spacing consistent.

@matatk matatk changed the title from Test injected landmarks to Support for dynamic content changes Nov 3, 2017

@matatk matatk merged commit ad0a2d3 into master Nov 3, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed

@matatk matatk deleted the test-injected-landmarks branch Nov 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment