Support for dynamic content changes #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a manual test for now.
* Compare element to undefined directly. * Improve the injected landmarks test page by adding nesting.
* This is for Firefox users, to test the MutationObserver stuff. * Use Mozilla addons-linter to check extensions before they are uploaded (currently Firefox only).
* Remove console output when disabling extension on certain URLs.
* Remove the "loading" ("...") indicator from the badge (it should be
robust enough not to need this, and it should not expose such internal
details to the end-user).
* Only say how long it took to find landmarks when they are (re-)found
as a result of a MutationObserver.
* Make LandmarksFinder.filter() cleaner using map().
This contributes to #84.
* Roll back to deepmerge 1.5.x due to change in behaviour TehShrike/deepmerge#83 * Add command definition for main-landmark. * Add translation text for main-landmark. * Simplify command handling in background script. * Make error throwing consistent.
All seems well except addons-linter is complaining about PNGs, though they have always shown up fine...
Thanks TehShrike/deepmerge#84 :-).
* Remove unused this.currentLandmarkElement() from LandmarksFinder. * Track which element is the <main>/role="main" element. * Add this.selectMainElement() to LandmarksFinder. * Handle the 'main-landmark' message in content.management.js. * Add info on skipping to the main landmark to the README. This completes the work started in f1331fa and closes #106.
* Tidy up mutation observer setup stuff. * Remove a logic error (spurious `return false`) from mutation observer mutation handler code. * Make comments and spacing consistent.
Fixes #107.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supports situations where the page changes dynamically and the landmarks change because of this, thus this closes #84 (as well as other issues, as noted in the commit messages).