New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar refinements #199

merged 17 commits into from Aug 21, 2018


1 participant

matatk commented Aug 21, 2018

  • Add message for forbidden pages.
  • Process some FIXMEs.
  • "popup" -> "pop-up" in UI message.

This completes and closes #180

matatk added some commits Aug 4, 2018

Refine sidebars; Remove debug info
* Properly determine when the popup encounters an error sending to a tab
  due to the tab either not being loaded, or being a forbidden page.
* Indicate in the sidebar when the page is forbidden (content scripts
  will not run).
* Indicate in the sidebar when the user has chosen to use the pop-up
  instead, and ask the user to close the sidebar.
* Remove some more console.log (the last, in fact) from src/

Note: several messages now need to be added regarding Landmarks being
      unable to run (applicable to all browsers) and sidebar-specific
Options improvements and tidying
* Preliminary support for displaying an explanatory message about the
  interface choice.
* Simplify the CSS using better selectors.
* Add some more spacing for legibility.

* Need to translate stuff!
* Need to figure out text alignment browser-agnostic-wise.
Fork sidebar from panel during build; Build tweaks
* Create panel.html and panel.js dynamically during the build, by
  copying popup.html and popup.js. The only difference in the HTML is that
  the sidebar version of the popup code is included in the sidebar
  panel.html (via text replacement during build). The code differences are
  around what the sidebar does when it starts up (and, in future, letting
  the user know that the popup will be used if the interface setting is
  set/changed that way).
* Clean up output of the build script somewhat.
* Move the ESLint configs closer to the code. In future, splash.js will
  probably be moved to src/code/ and src/static/.eslintrc.json would be
Correctly handle interface implications
* The sidebar will always update if shown, even if it is not the primary
  interface. This is becuase we cannot close it when it is disabled, there
  is no need to limit it to not working properly when disabled.
* Insert a (currently placeholder) warning about the interface settings
  when the sidebar is open but is not the primary interface.
* Simplify the background script accordingly; it no longer needs to
  track if we think we should or should not be using the sidebar.
Sidebar settings and info messages
* Include explainer for chosen sidebar settings in translation messages.
* Tweak ordering of stuff in options CSS.
* Add info message to explain to the user when the sidebar is open but
  is not the primary interface.
* The message can be dismissed.
* The state of the dismissal is recorded and can be reset via the
  options page.

* The messages are just placeholders and need translating.
* Eventually different messages will be needed for Opera (currently
  working on Firefox specifically).
Sidebar/settings smoothness
* Add a button to open settings from the sidebar.
* Translate more messages.
Fix UI optoins removal
On !{Firefox, Opera} the regex for replacing UI sections in options.html
did not allow for multiple separate UI bits. This was fixed by making it
both non-greedy and globally-matching.
* Add message for forbidden pages.
* Process some FIXMEs.
* "popup" -> "pop-up" in UI message.

@matatk matatk merged commit 3e0734a into master Aug 21, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed

@matatk matatk deleted the sidebar-refinements branch Aug 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment