New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grab bag #207

merged 19 commits into from Oct 27, 2018


1 participant

matatk commented Oct 27, 2018

A range of small issues addressed for 2.4.0.

matatk added some commits Oct 21, 2018

Don't need to check DOMContentLoaded the scripts are included via <script> tags at the end of the <body>.

Closes #192.
Clean up content script injector definition
This uses ternery operator notation to allow the injector to appear as
one const variable in the generated code.
Clean up defaults definitions
Unfortunately this still leaves some "Object.freeze()" calls in code
that doesn't use it, but I can't see a clean way to get rid of these.
Cleaner conditional code in background script
* Declare functions at outer scope.  It is then unnecessary to define
  them using ternary notation, as the minifier will remove them.
* Ensure DevTools stuff does not get build for Edge.
* More conditional checking where stuff is used.
* Terser now removes various things like sidebar-related variables on
  Chrome automatically.

Fixes #195.
DRY testing for non-special pages
Instead of checking for special pages, check that a page is
content-scriptable, as this is more in line with what the extension
wants to do.

Fixes #206.
Conditional code in options script
Only add the interface option on sidebar-supporting browsers (the
related functions are automatically pruned).

Also fixes #195 :-).
Rename message files
* In line with other "assembled" files.
* This might make merging the "show all" changes back in from that commit more interesting :-).
Only ask for landmarks once at a time
When multiple GUIs are open, be sure to only request landmarks from the
active tab once. Fixes #205.
Rename isHidden() to isVisuallyHidden() for clarity
As per the recently-retconned PR notes for #85.

Partly addresses #197.
Update documentation around unlabelled form and region
* Clarify support in the README (and why).
* Tweak the rationale in the README.
* Clarify behaviour in comments.

Fixes #197.
Remove Opera note from README
2.3.1 was reviewed recently.

@matatk matatk merged commit 6e4e940 into master Oct 27, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed

@matatk matatk deleted the grab-bag branch Oct 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment