New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file missing from zip #212

Merged
merged 1 commit into from Oct 28, 2018

Conversation

1 participant
@matatk
Owner

matatk commented Oct 28, 2018

The changes in 3417085 borked things in
an odd way: devtoolsPanel.js was missing from the created zip files.

Initially I tried fixing things by restoring the natural async behaviour
of the zip creation and linting only after the zip has made. Output from
the build script is not as neat.

This does make one change to how archiver is used: it passes false
instead of an empty string as the path under which the build directory
tree is to be added to the zip file. This is in line with the latest
archiver README.

That alone didn't actually solve things. I then changed the rollup code
to use await rather than promises for writing the bundle (as per the
current code examples on the rollup site). Now it's working again.

Decided not to try going back to the previous archiver code, as not
really sure if what I was doing regarding the handling of promises was
right (didn't seem great, mixed in with async/await).

Fix file missing from zip
The changes in 3417085 borked things in
an odd way: devtoolsPanel.js was missing from the created zip files.

Initially I tried fixing things by restoring the natural async behaviour
of the zip creation and linting only after the zip has made. Output from
the build script is not as neat.

This does make one change to how archiver is used: it passes false
instead of an empty string as the path under which the build directory
tree is to be added to the zip file. This is in line with the latest
archiver README.

That alone didn't actually solve things. I then changed the rollup code
to use await rather than promises for writing the bundle (as per the
current code examples on the rollup site). Now it's working again.

Decided not to try going back to the previous archiver code, as not
really sure if what I was doing regarding the handling of promises was
right (didn't seem great, mixed in with async/await).

@matatk matatk merged commit 369326d into master Oct 28, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@matatk matatk deleted the fix-devtools branch Oct 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment