Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPACEFISH_HOST_SHOW valid values #196

Closed
halbrd opened this issue Jun 20, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@halbrd
Copy link

commented Jun 20, 2019

Bug Report

Current Behavior
According to the docs at https://spacefish.matchai.me/docs/Options.html#char, the valid values for SPACEFISH_HOST_SHOW should be true and false.

(no SSH session was active)

SPACEFISH_HOST_SHOW = true does not cause the host to be displayed
SPACEFISH_HOST_SHOW = always causes the host to be displayed

Expected Behavior
The docs imply that

SPACEFISH_HOST_SHOW = true should cause the host to be displayed
SPACEFISH_HOST_SHOW = always should be invalid

Relevant Fish Configuration

set SPACEFISH_PROMPT_ORDER user host dir

set SPACEFISH_HOST_SHOW         always
set SPACEFISH_HOST_PREFIX       'on '
set SPACEFISH_HOST_COLOR        red
set SPACEFISH_HOST_COLOR_SSH    green

Environment

  • Spacefish version: 2.6.0
  • Fish version: fish, version 3.0.2
  • Fish plugin manager: oh-my-fish
  • Terminal emulator: Konsole
  • Operating system: Manjaro 18.0.4

Possible Solution
I think the docs just need to be updated.

Additional context/Screenshots
N/A

@matchai matchai referenced this issue Jul 1, 2019

Merged

fix: correct incorrectly named config options #198

7 of 10 tasks complete

@matchai matchai closed this in #198 Jul 1, 2019

@matchai

This comment has been minimized.

Copy link
Owner

commented Jul 2, 2019

🎉 This issue has been resolved in version 2.6.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.