New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove color from prefix/suffix #133

Merged
merged 4 commits into from Jan 9, 2019

Conversation

4 participants
@matchai
Copy link
Owner

matchai commented Jan 8, 2019

Description

Remove the #fff color from section prefixes and suffixes to make them visible by default on light terminal themes.

BREAKING CHANGE: Because prefix and suffix colors are no longer set to #fff, the color of prefix and suffix will be set to the default foreground color of your shell.

Motivation and Context

Closes #132

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Screenshots (if appropriate):

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux

Checklist:

  • I have checked that no other PR duplicates mine
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

matchai added some commits Jan 8, 2019

fix: remove color from prefix/suffix
BREAKING CHANGE: Because prefix and suffix colors are no longer set to #fff, the color of prefix and suffix will be set to the default foreground color of your shell.

@matchai matchai requested a review from Snuggle Jan 8, 2019

@matchai matchai added the Type: Bug label Jan 8, 2019

@sirMerr

sirMerr approved these changes Jan 8, 2019

@Snuggle

Snuggle approved these changes Jan 9, 2019

Copy link
Collaborator

Snuggle left a comment

Looks good to me!
Darn those pesky light-background users! 😋

(Just kidding. c:)

@ohcibi

This comment has been minimized.

Copy link

ohcibi commented Jan 9, 2019

Darn those pesky light-background users! 😋

🕴

@matchai matchai merged commit 319f0b0 into master Jan 9, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@matchai matchai deleted the fix-132 branch Jan 9, 2019

matchai pushed a commit that referenced this pull request Jan 9, 2019

chore(release): 2.0.0 [skip ci]
# [2.0.0](v1.12.4...v2.0.0) (2019-01-09)

### Bug Fixes

* remove color from prefix/suffix ([#133](#133)) ([319f0b0](319f0b0))

### BREAKING CHANGES

* Because prefix and suffix colors are no longer set to #fff, the color of prefix and suffix will be set to the default foreground color of your shell.
@matchai

This comment has been minimized.

Copy link
Owner

matchai commented Jan 9, 2019

🎉 This PR is included in version 2.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment