New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dotnet project detection #145

Merged
merged 4 commits into from Feb 2, 2019

Conversation

Projects
None yet
2 participants
@yjpark
Copy link
Contributor

yjpark commented Jan 21, 2019

Description

Check existence of paket.dependencies (if use paket to manage packages) or *.fsproj (for F# projects)

Motivation and Context

Just want to show dotnet version for F# project, and in parent folder.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Screenshots (if appropriate):

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux

Checklist:

  • I have checked that no other PR duplicates mine
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
@matchai

This comment has been minimized.

Copy link
Owner

matchai commented Jan 23, 2019

Hey @yjpark! Looks like a great addition to spacefish Thank you for taking the time to write up this PR! 😄

It seems this feature doesn't already exist in spaceship. In an effort to maintain feature parity with spaceship, we ask that an equivalent issue or PR gets created on their project before it gets implemented in spacefish. 🚀

matchai added a commit to matchai/spaceship-prompt that referenced this pull request Jan 31, 2019

Add detection for F# project files
This is a downstream improvement that was proposed by @yjpark in matchai/spacefish#145

matchai added some commits Feb 2, 2019

@matchai

matchai approved these changes Feb 2, 2019

Copy link
Owner

matchai left a comment

Sorry for the hold-up.
The feature has been merged upstream, so we can now go ahead and release it on spacefish.

Cheers! 🍻

@matchai matchai merged commit c104b04 into matchai:master Feb 2, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
@matchai

This comment has been minimized.

Copy link
Owner

matchai commented Feb 2, 2019

🎉 This PR is included in version 2.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment