Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upImprove dotnet project detection #145
Conversation
This comment has been minimized.
This comment has been minimized.
|
Hey @yjpark! Looks like a great addition to spacefish Thank you for taking the time to write up this PR! It seems this feature doesn't already exist in spaceship. In an effort to maintain feature parity with spaceship, we ask that an equivalent issue or PR gets created on their project before it gets implemented in spacefish. |
matchai
added
Upstream Issue
Status: Blocked
Type: Enhancement
labels
Jan 23, 2019
added a commit
to matchai/spaceship-prompt
that referenced
this pull request
Jan 31, 2019
matchai
removed
Status: Blocked
Upstream Issue
labels
Feb 2, 2019
matchai
added some commits
Feb 2, 2019
matchai
approved these changes
Feb 2, 2019
|
Sorry for the hold-up. Cheers! |
matchai
merged commit c104b04
into
matchai:master
Feb 2, 2019
This comment has been minimized.
This comment has been minimized.
|
The release is available on GitHub release Your semantic-release bot |
matchai
added
the
Status: Released
label
Feb 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
yjpark commentedJan 21, 2019
Description
Check existence of paket.dependencies (if use paket to manage packages) or *.fsproj (for F# projects)
Motivation and Context
Just want to show dotnet version for F# project, and in parent folder.
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?
Checklist: