New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: lock the fishtape test dependency to v1 #152

Merged
merged 1 commit into from Feb 8, 2019

Conversation

Projects
None yet
1 participant
@matchai
Copy link
Owner

matchai commented Feb 8, 2019

Description

Fishtape v2 was released today, which breaks our tests.
Until we migrate to using fishtape v2, we'll keep the release of fishtape locked to the last commit of fishtape v1.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Screenshots (if appropriate):

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux

Checklist:

  • I have checked that no other PR duplicates mine
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
ci: lock the fishtape test dependency to v1
Fishtape v2 was released today, which breaks our tests. Until we migrate
to using fishtape v2, we'll keep the version locked.

@matchai matchai merged commit f872354 into master Feb 8, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@matchai matchai deleted the lock-fishtape branch Feb 8, 2019

@matchai

This comment has been minimized.

Copy link
Owner Author

matchai commented Feb 14, 2019

🎉 This PR is included in version 2.2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment