Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in venv generic names variables #167

merged 1 commit into from Mar 2, 2019


None yet
2 participants
Copy link

k-lyda commented Mar 2, 2019


I think this there is a leftover from migrating venv section from Spaceship prompt - name of the variable containing venv generic names is SPACESHIP_VENV_GENERIC_NAMES instead of SPACEFISH_VENV_GENERIC_NAMES

Motivation and Context

In the documentation name for this var is SPACEFISH_VENV_GENERIC_NAMES. If you add a line to according to the documentation, the generic names array is not updated, cause spaceship does not take var SPACEFISH_VENV_GENERIC_NAMES into account, it only looks for SPACESHIP_VENV_GENERIC_NAMES

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Screenshots (if appropriate):

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux


  • I have checked that no other PR duplicates mine
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

matchai approved these changes Mar 2, 2019

Copy link

matchai left a comment

Good catch @k-lyda. 😄
Thanks for fixing that up!

@matchai matchai merged commit 8a3585c into matchai:master Mar 2, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
deploy/netlify Deploy preview ready!

This comment has been minimized.

Copy link

matchai commented Mar 2, 2019

@all-contributors please add @k-lyda for bug


This comment has been minimized.

Copy link

allcontributors bot commented Mar 2, 2019


I've put up a pull request to add @k-lyda! 🎉

matchai pushed a commit that referenced this pull request Mar 2, 2019

chore(release): 2.3.1 [skip ci]
## [2.3.1](v2.3.0...v2.3.1) (2019-03-02)

### Bug Fixes

* correct typo in venv configuration variables ([#167](#167)) ([8a3585c](8a3585c))

This comment has been minimized.

Copy link

matchai commented Mar 2, 2019

🎉 This PR is included in version 2.3.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matchai added a commit that referenced this pull request Mar 2, 2019

docs: add k-lyda as a contributor (#168)
Adds @k-lyda as a contributor for bug.

This was requested by matchai [in this comment](#167 (comment))

Co-authored-by: null <allcontributors[bot]>
Co-authored-by: Matan Kushner <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.