Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cargo package manager and refactor existing package #171

Merged
merged 13 commits into from Mar 8, 2019

Conversation

Projects
None yet
3 participants
@sirMerr
Copy link
Collaborator

sirMerr commented Mar 3, 2019

Description

Make package section support cargo package manager. Additionally, update current implementation of __sf_section_package.fish to use jq and python to go through package.json as spaceship does as a performance boost.

Motivation and Context

Closes #143

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Screenshots (if appropriate):

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux

Checklist:

  • I have checked that no other PR duplicates mine
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

@sirMerr sirMerr requested a review from matchai Mar 3, 2019

@sirMerr sirMerr force-pushed the feat/cargo branch from 7b437b8 to 625472e Mar 3, 2019

sirMerr added some commits Mar 3, 2019

@matchai
Copy link
Owner

matchai left a comment

Looks great @sirMerr! 😄
Just a couple small suggested changes and we're ready to merge 🏎💨

matchai and others added some commits Mar 4, 2019

Update functions/__sf_section_package.fish
Co-Authored-By: sirMerr <letiffany.nguyen@gmail.com>
Update functions/__sf_section_package.fish
Co-Authored-By: sirMerr <letiffany.nguyen@gmail.com>
Update functions/__sf_section_package.fish
Co-Authored-By: sirMerr <letiffany.nguyen@gmail.com>

@sirMerr sirMerr requested a review from matchai Mar 4, 2019

All addressed

@matchai

This comment has been minimized.

Copy link
Owner

matchai commented Mar 4, 2019

@sirMerr You may want to update the documentation in Options.md to mention the new Cargo support in the package section: https://github.com/matchai/spacefish/blob/master/docs/Options.md#package-version-package

Here is the equivalent spaceship documentation: https://github.com/denysdovhan/spaceship-prompt/blob/master/docs/Options.md#package-version-package

@Snuggle
Copy link
Collaborator

Snuggle left a comment

I think a couple things here need a little more explanation, but I can't see anything glaring. 🙂

Show resolved Hide resolved tests/__sf_section_package.test.fish
Show resolved Hide resolved functions/__sf_section_package.fish

sirMerr added some commits Mar 8, 2019

@matchai

matchai approved these changes Mar 8, 2019

Copy link
Owner

matchai left a comment

Looks great! 😄
Thanks a lot, Tiff!

🚀🚀🚀🚀

@matchai matchai merged commit 0064d2d into master Mar 8, 2019

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@matchai matchai deleted the feat/cargo branch Mar 8, 2019

@matchai

This comment has been minimized.

Copy link
Owner

matchai commented Mar 8, 2019

@all-contributors please add @sirMerr for tests

@allcontributors

This comment has been minimized.

Copy link
Contributor

allcontributors bot commented Mar 8, 2019

@matchai

I've put up a pull request to add @sirMerr! 🎉

matchai pushed a commit that referenced this pull request Mar 8, 2019

chore(release): 2.4.0 [skip ci]
# [2.4.0](v2.3.1...v2.4.0) (2019-03-08)

### Features

* add cargo package manager and refactor existing package section ([#171](#171)) ([0064d2d](0064d2d))
@matchai

This comment has been minimized.

Copy link
Owner

matchai commented Mar 8, 2019

🎉 This PR is included in version 2.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.