Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation for displaying AWS info #175

Merged
merged 1 commit into from Mar 11, 2019

Conversation

Projects
None yet
2 participants
@lynzt
Copy link
Contributor

lynzt commented Mar 10, 2019

Description

Fix the documentation for configuring the display of AWS info.

Motivation and Context

SPACESHIP_AWS_SHOW false does not suppress the output of AWS information

SPACEFISH_AWS_SHOW false suppresses AWS info
SPACEFISH_VENV_COLOR cccccc updates the AWS info color

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux

Checklist:

  • I have checked that no other PR duplicates mine
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
@matchai
Copy link
Owner

matchai left a comment

Good catch, @lynzt!
Thank you for your contribution. 😄

@matchai matchai merged commit 0d7c339 into matchai:master Mar 11, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
@matchai

This comment has been minimized.

Copy link
Owner

matchai commented Mar 11, 2019

@all-contributors please add @lynzt for documentation

@allcontributors

This comment has been minimized.

Copy link
Contributor

allcontributors bot commented Mar 11, 2019

@matchai

I've put up a pull request to add @lynzt! 🎉

matchai added a commit that referenced this pull request Mar 11, 2019

docs: add lynzt as a contributor (#176)
Adds @lynzt as a contributor for doc.

This was requested by matchai [in this comment](#175 (comment))

Co-authored-by: null <allcontributors[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.